Hi! :wave: I’m attempting to integrate the Pinot J...
# pinot-dev
g
Hi! 👋 I’m attempting to integrate the Pinot JDBC with Jooq so it can build sql and manage connections for us. This is not officially supported at this point, but it looks like the only change that would be needed to support it, is to add the
execute()
function (no params) to the PinotPreparedStatement. There are already several
execute(…)
functions with params, and an
executeQuery()
function with no params. Is there a reason this hasn’t been done already? Or why was the
executeQuery()
function named differently than the rest? Currently Jooq calls
execute()
and it hits this since it hasn’t been overridden. I’m happy to make a PR to add this functionality but wanted to check first. Thanks!
Could I just add this?
Copy code
@Override
public ResultSet execute()
    throws SQLException {
  executeQuery();
}
z
Hi team and Grace, I am also using jooq for querying Pinot but running into an exception when there is no match. I think the root cause is b/c: 1. PinotStatement returns a
null
when there is empty-row(no match) result 2. Then Jooq tries to insert an
updateCount
row which is not able to be parsed with the original cols I wonder if this has any existing solution or we should update
PinotStatement.execute()
to return a non-null ResultSet with 0 row instead(this looks the correct fix since an empty-row ResultSet should still be valid based on the discussion here).
g
nice catch