https://pinot.apache.org/ logo
Join Slack
Powered by
# segment-write-api
  • c

    Chinmay Soman

    03/13/2021, 12:18 AM
    but its been a while for me for Flink - maybe there are newer things that I don't know about
  • c

    Chinmay Soman

    03/13/2021, 12:18 AM
    lets wait for Yupeng's comments
  • n

    Neha Pawar

    03/13/2021, 12:19 AM
    Okay. Let's have a call on Tuesday? We've been going back and forth on this async discussion
  • c

    Chinmay Soman

    03/13/2021, 12:19 AM
    I also think - the first version shouldn't try to over optimize
    ➕ 2
  • c

    Chinmay Soman

    03/13/2021, 12:19 AM
    keep it simple
  • c

    Chinmay Soman

    03/13/2021, 12:19 AM
    sounds good @ Tuesday
  • y

    Yupeng Fu

    03/13/2021, 12:48 AM
    yes, in current proposal, checkpoint not supported for pinot sink
  • y

    Yupeng Fu

    03/13/2021, 12:48 AM
    so if the connector fails, the job has to be relaunched
  • y

    Yupeng Fu

    03/13/2021, 12:48 AM
    as i explained in the connector design doc
  • y

    Yupeng Fu

    03/13/2021, 12:49 AM
    however, it’s still possible to support checkpoint in future
  • y

    Yupeng Fu

    03/13/2021, 12:49 AM
    that checkpoint shall remember the last successful segment name in the folder
  • y

    Yupeng Fu

    03/13/2021, 12:49 AM
    and discard other segments whose sequence numbers are higher
  • n

    Neha Pawar

    03/16/2021, 2:52 PM
    set up a meeting for 11am. Please move it around if that time doesnt work @User @User
  • y

    Yupeng Fu

    03/16/2021, 4:33 PM
    sg
  • y

    Yupeng Fu

    03/17/2021, 6:43 PM
    updated the doc. PTAL
  • c

    Chinmay Soman

    03/17/2021, 6:51 PM
    will do
  • n

    Neha Pawar

    03/18/2021, 2:41 AM
    should we have another meeting tomorrow?
  • y

    Yupeng Fu

    03/18/2021, 5:05 AM
    ok for me
  • c

    Chinmay Soman

    03/18/2021, 5:38 PM
    👍
  • y

    Yupeng Fu

    03/18/2021, 6:33 PM
    will 3:30-4 work for you @User
  • n

    Neha Pawar

    03/18/2021, 6:36 PM
    yes works
  • x

    Xiang Fu

    03/18/2021, 10:54 PM
    https://github.com/apache/incubator-pinot/issues/6606
  • n

    Neha Pawar

    03/26/2021, 1:44 AM
    File based SegmentWriter: https://github.com/apache/incubator-pinot/pull/6718
  • n

    Neha Pawar

    04/05/2021, 10:58 PM
    SegmentUploader impl: https://github.com/apache/incubator-pinot/pull/6740
  • n

    Neha Pawar

    04/07/2021, 11:39 PM
    folks, reminder to please review 🙂 ☝️
  • n

    Neha Pawar

    04/07/2021, 11:40 PM
    there’s no new code, just existing code moved around
  • n

    Neha Pawar

    04/07/2021, 11:40 PM
    @User @User @User
    y
    • 2
    • 1
  • c

    Chinmay Soman

    04/07/2021, 11:46 PM
    yes will do by tonight
  • c

    Chinmay Soman

    04/08/2021, 5:01 AM
    done - sorry for the delay
  • n

    Neha Pawar

    04/08/2021, 4:14 PM
    thanks!