https://pinot.apache.org/ logo
Join Slack
Powered by
# feat-better-schema-evolution
  • s

    Subbu Subramaniam

    01/03/2020, 10:19 PM
    thanks, haibo. will look
    šŸ˜€ 1
  • h

    Haibo Wang

    01/13/2020, 7:32 PM
    @User /@User /@User appreciate it if anyone can help to review šŸ™‚ ^^
  • s

    Subbu Subramaniam

    01/13/2020, 7:37 PM
    yes, will do this week
  • h

    Haibo Wang

    01/13/2020, 7:42 PM
    thank you!
  • h

    Haibo Wang

    02/03/2020, 1:29 AM
    ^ @User can you take another look when you have time
  • s

    Subbu Subramaniam

    02/03/2020, 4:42 AM
    i was down with a flu for a week, will get to it this week
  • h

    Haibo Wang

    02/03/2020, 4:53 AM
    Ah. Take care! Hope you get better soon
  • h

    Haibo Wang

    02/10/2020, 8:12 PM
    ^ @User ping šŸ˜„
  • h

    Haibo Wang

    02/10/2020, 8:12 PM
    would like to get this in soon
  • s

    Subbu Subramaniam

    02/10/2020, 8:51 PM
    @User had promised to re-factor the code a bit so that you can go in after that. He is available starting Wed.
  • j

    Jackie

    02/11/2020, 3:50 AM
    I'll try to refactor the code and get a way to directly construct the data source for column with default values. Will try to get it done by this week
  • h

    Haibo Wang

    02/11/2020, 9:35 PM
    Will wait for it. Thank you
  • s

    Subbu Subramaniam

    02/12/2020, 12:59 AM
    @User our main objection to this PR is that the newly added columns are treated a virtual columns (even though they may not be). I have given some basic comments. Perhaps it is best to meet (maybe this Fri?) and resolve this. I will ask @User once he is back tomorrow
  • k

    Kishore G

    02/12/2020, 1:02 AM
    whats the easiest way for me to get up to date on this topic?
  • k

    Kishore G

    02/12/2020, 1:02 AM
    can we start a thread on dev?
  • k

    Kishore G

    02/12/2020, 1:03 AM
    I am bit concerned if Subbus statement is true that we are treating newly added columns as virtual columns
  • h

    Haibo Wang

    02/12/2020, 1:34 AM
    There were actually some discussions in an earlier diff, on whether we should use virtual column provider to surface the newly added columns in the consuming segment: https://github.com/apache/incubator-pinot/pull/4774#issuecomment-549636862
  • h

    Haibo Wang

    02/12/2020, 1:34 AM
    Happy to come over and discuss more
  • h

    Haibo Wang

    02/12/2020, 1:34 AM
    My calendar is open tomorrow. Let me know whether you can find a time on Wed @User
  • h

    Haibo Wang

    02/12/2020, 1:48 AM
    I’m also available Thur after 1pm, and Fri before 4pm
  • s

    Subbu Subramaniam

    02/12/2020, 9:52 PM
    Thu 2-3 is a possibility. @User, @User are you available? I can also try to be avail 3-4
  • s

    Subbu Subramaniam

    02/12/2020, 9:53 PM
    Fri 3-4 also works
  • n

    Neha Pawar

    02/12/2020, 9:53 PM
    all 3 times work for me
  • j

    Jackie

    02/12/2020, 9:54 PM
    Me too, all 3 times work
  • h

    Haibo Wang

    02/12/2020, 10:32 PM
    Me too, all 3 times work
  • h

    Haibo Wang

    02/12/2020, 10:33 PM
    @User could you pick a time and book a room?
  • s

    Subbu Subramaniam

    02/12/2020, 11:29 PM
    I have booked a room in our building (1101 Maude, the same one you came to last time) from 3-4 on Friday. Haibo, I hope you are ok if it spills over a bit beyond 4. if not, I will try to make it 12-2, we can grab lunch and then meet.
  • h

    Haibo Wang

    02/13/2020, 2:32 AM
    going a bit beyond 4 is fine. Thanks!
  • h

    Haibo Wang

    01/27/2021, 4:17 AM
    @User has left the channel
  • n

    Neha Pawar

    05/04/2022, 8:45 PM
    @Neha Pawar has left the channel