# config-tuner
- s
Sidd
11/25/2020, 8:40 PMok taking a step back here.. when you refer to Tuner interface, is it the engine that is actually doing the tuning or the high level pluggable interface. The current RecommenderDriver doesn't implement an interface as of now - k
Kishore G
11/25/2020, 8:41 PMzoom call? - k
Kishore G
11/25/2020, 8:41 PMits just an interface that will be called periodically and what ever is the output will be set in Helix - k
Kishore G
11/25/2020, 8:42 PMits really that simple - k
Kishore G
11/25/2020, 8:42 PMnow you can make recommenderDriver implement Tuner interface and have a init method and apply method - s
Sidd
11/25/2020, 8:42 PMyes.. I just wanted to see how recommenderDriver can fit into this - k
Kishore G
11/25/2020, 8:43 PMok, is it clear now? - s
Sidd
11/25/2020, 8:44 PMyes. Makes sense - s
Sidd
11/25/2020, 8:45 PMSorry for the confusion - s
Sidd
11/25/2020, 8:45 PMwe can implement any custom tuner and register with TableConfigTunerRegistry - s
Sidd
11/25/2020, 8:45 PMimplement init and apply - k
Kishore G
11/25/2020, 8:46 PMexactly - k
Kishore G
11/25/2020, 8:47 PMi am sure this we will enhance the annotations - k
Kishore G
11/25/2020, 8:47 PMlike add priority etc - k
Kishore G
11/25/2020, 8:47 PMor how often it should be called etc - k
Kishore G
11/25/2020, 8:47 PMbut for now it should be really simple - c
Chinmay Soman
12/01/2020, 12:16 AM<!here> I've modified the PR based on this discussion. Here's the summary:Copy code1. Added a TableConfigTuner interface with explicit init and apply methods. 2. Added a new annotation type 'Tuner' to auto discover such classes. - c
Chinmay Soman
12/01/2020, 12:16 AMI haven't integrated it with RecommendedDriver yet. we can do that in the next PR or so - c
Chinmay Soman
12/01/2020, 12:16 AMplease take a look when you get a chance. THanks ! - c
Chinmay Soman
12/02/2020, 6:26 PM<!here> please review this when you get a chance: https://github.com/apache/incubator-pinot/pull/6255 - s
Sidd
12/02/2020, 6:26 PMI will review today - c
Chinmay Soman
12/02/2020, 6:33 PMThanks a lot - c
Chinmay Soman
12/09/2020, 6:06 PM<!here> any way this can be reviewed today ? - c
Chinmay Soman
12/09/2020, 6:06 PMHappy to discuss further if there are any open questions - s
Sidd
12/09/2020, 6:07 PMyes I am sorry... got swamped with other work and missed this. Will review this today positively - c
Chinmay Soman
12/09/2020, 6:07 PMno worries ! - c
Chinmay Soman
12/09/2020, 6:07 PMjust wanted to see if there's anything major that needs changes - s
Sidd
12/09/2020, 6:07 PMyeah definitely review today soon - c
Chinmay Soman
12/09/2020, 6:07 PMthank you ! - a
Anirudh
02/09/2021, 3:48 PM@User has left the channel