https://pinot.apache.org/ logo
Join Slack
Powered by
# feat-text-search
  • k

    Kishore G

    11/20/2019, 8:21 PM
    @User can you give read access to anyone with the link?
  • s

    Sidd

    11/20/2019, 8:26 PM
    So I have shared with apache-pinot-dev@googlegroups.com and few specific folks whose email id I know. I obviously want to share with everyone but the sharing link in google doc written in your linkedin account does not give "allow anyone with the link to view/edit". It only gives "allow anyone at LinkedIn with the link to view/edit"
  • s

    Sidd

    11/20/2019, 8:27 PM
    Can we add people to apache-pinot-dev google group
  • k

    Kishore G

    11/20/2019, 8:29 PM
    is there any reason that this has to be internal to linkedin?
    s
    • 2
    • 2
  • s

    Sidd

    11/20/2019, 8:29 PM
    I have also shared with dev@pinot.apache.org but it looks like our mailing list doesn't give automatic access
  • k

    Kishore G

    11/20/2019, 8:29 PM
    if not, you can transfer the ownership to your personal apache id
  • s

    Sidd

    11/20/2019, 9:02 PM
    I added the document to my personal id. Please read that document -- https://docs.google.com/document/d/19uLti7wwl7nPlDuy6cUVnLOll2C8u3YtUITbNj0TT5o/edit?usp=sharing
  • s

    Sidd

    01/16/2020, 11:27 PM
    <!here> I have created a new PR after cleaning up the POC code (merging some orthogonal part of it as separate PR and making some additional changes based on the design doc) and addressing the review comments.
  • s

    Sidd

    01/16/2020, 11:27 PM
    https://github.com/apache/incubator-pinot/pull/4993
  • s

    Sidd

    01/21/2020, 6:36 PM
    Few things : The current PR controls the creation and loading of Lucene text index through knobs in TableConfig (IndexingConfig), SegmentGeneratorConfig and IndexLoadingConfig. As per the design doc, we plan to implement a new data type TEXT. So once the segment creator sees it in the schema, it automatically creates the text index on that column. I had intended to do this change in follow-up PR (soon after) which will add the new data type and also remove the knobs from TableConfig.
  • s

    Sidd

    01/21/2020, 6:37 PM
    @User and I discussed this and undoing anything from TableConfig is not allowed. So this is the tentative sequence of steps
  • s

    Sidd

    01/21/2020, 6:37 PM
    (1) Add a PR that just adds the new type -- keep this disabled
  • s

    Sidd

    01/21/2020, 6:38 PM
    (2) Rebase my current PR on this to leverage the new type.
  • s

    Sidd

    01/21/2020, 6:38 PM
    One question is that if we want to ever create a text index on STRING/BYTES column then we will still need the knobs in TableConfig, IndexingConfig
  • s

    Sidd

    01/21/2020, 6:42 PM
    Or we can merge this PR (with feature disabled) and do the data type as follow-up
  • k

    Kishore G

    01/21/2020, 6:42 PM
    lets make sure we agree on the desired state
  • k

    Kishore G

    01/21/2020, 6:43 PM
    are we saying the only way to enable text indexing is mark it as TEXT column?
  • s

    Sidd

    01/21/2020, 6:45 PM
    Yes, assuming users are probably not going to run standard filter operations on such data and the column will only be used in text_match filters
  • s

    Sidd

    01/21/2020, 6:50 PM
    However, having text indexing support on existing STRING/BYTES column will let people use this feature without adding a new column and just a simple table config change.
    k
    s
    • 3
    • 17
  • k

    Kishore G

    01/21/2020, 6:50 PM
    we have never done anything like that until now, for e.g. marking something as dimension, metric, timefield does not automatically add indexes
  • r

    Rich

    09/03/2020, 7:23 PM
    👋 I’m here! What’d I miss?
    👋 1
    m
    • 2
    • 1
  • k

    Kishore G

    09/03/2020, 7:32 PM
    should we change the topic of this channel and point to the docs now?
    👍 2
  • r

    Rich

    09/04/2020, 12:17 AM
    @User has left the channel
  • m

    Matt

    01/12/2021, 2:35 AM
    Hello, My text index somehow stopped working. it is now giving intermittent results. For eg: following is working
    select * from mytable where regexp_likg(log, '0D82F520-62C8-9914-14B8-4C2331E54075')
  • m

    Matt

    01/12/2021, 2:35 AM
    But this one will not
    select * from mytable where text_match('0D82F520-62C8-9914-14B8-4C2331E54075')
  • m

    Matt

    01/12/2021, 2:36 AM
    any pointers how to debug?
  • k

    Kishore G

    01/12/2021, 2:41 AM
    Can you post this on #C011C9JHN7R
  • m

    Matt

    01/12/2021, 2:55 AM
    ok will do
  • k

    Kavin Kuppusamy

    11/06/2021, 5:54 PM
    @User has left the channel
  • s

    Subbu Subramaniam

    01/06/2022, 12:36 AM
    @User has left the channel