Apache Pinot

One thing is missing right now is that we cannot short-circuit the always false predicate

For always false, we need to put a place holder filter to represent that though

You can remove the predicate only when it evaluates to `true` or it evaluates to `false` as a child under `AND`

I don't think remove a predicate that evaluates to true will work in all cases. For example if we remove `intColumn != 4.4` from `SELECT * FROM mytable WHERE intColumn != 4.4 OR intColumn = 5.5` then the query will become `SELECT * FROM mytable WHERE intColumn = 5.5` which is semantically incorrect.

Also, note that `SELECT * FROM mytable WHERE intColumn = 5.5`  will throw an exception on the server side since we are comparing intColumn with 5.5.

I think we need a more generic mechanism.

The logic is quite simple, and we have similar logic on server side segment pruner

It's a recursive algorithm. Under `AND`, `true` can be removed, `false` result in the whole `AND` as `false`; Under `OR`, `false` can be removed, `true` result in the whole `OR` as `true`; At root level, `true` can be removed, `false` result in empty result

We can take small steps. To unblock the issue of parsing error, we can first only convert the integral value to a format without decimal part (`1.0` -&gt; `1`)

Thats too narrow and not sure if it solves the underlying problem. I agree we should take small steps, but while keeping the big picture in mind so that we are moving towards a complete solution that works :slightly_smiling_face: