https://pinot.apache.org/ logo
Join Slack
Powered by
# feat-rt-seg-complete
  • s

    Subbu Subramaniam

    04/02/2020, 5:36 PM
    you can just send us the urls right?
  • s

    Subbu Subramaniam

    04/02/2020, 5:36 PM
    mcvsubbu@gmail.com works for me
  • s

    Subbu Subramaniam

    04/02/2020, 5:36 PM
    better, ssubrama@linkedin.com
  • t

    Ting Chen

    04/02/2020, 5:37 PM
    https://uber.zoom.us/j/256469069
  • t

    Ting Chen

    04/02/2020, 5:40 PM
    Please check if you can access the url.
  • s

    Seunghyun

    04/02/2020, 5:54 PM
    yeah i have the access
    👍 1
  • n

    Neha Pawar

    04/02/2020, 7:02 PM
    i'll try to join as well, neha.pawar18@gmail.com
  • t

    Ting Chen

    04/02/2020, 8:43 PM
    thanks. Neha, it seems that the url is enough -- i removed any domain restriction on the meeting. So email is not needed. Can you just access the link to see if you can access it?
  • n

    Neha Pawar

    04/03/2020, 4:53 PM
    i havent gotten a chance to look through the PR yet. Please meet without me. i'll sync up with Ting if i have questions later
  • s

    Subbu Subramaniam

    04/03/2020, 4:56 PM
    Is there a PR? I thought it was a design discussion
  • t

    Ting Chen

    04/03/2020, 4:58 PM
    PR 4914 is the PR.
  • t

    Ting Chen

    04/03/2020, 4:58 PM
    Sorry folks. I have a Production emergency issue right now. Can we talk around 10:30am?
  • t

    Ting Chen

    04/03/2020, 4:58 PM
    Sorry for the short notice.
  • s

    Subbu Subramaniam

    04/03/2020, 4:59 PM
    ok
  • s

    Subbu Subramaniam

    04/03/2020, 5:00 PM
    I have added a note in the design doc with a question
  • t

    Ting Chen

    04/03/2020, 5:24 PM
    can we meet now?
  • t

    Ting Chen

    04/03/2020, 5:24 PM
    @User @User
  • t

    Ting Chen

    04/03/2020, 5:24 PM
    @User
  • t

    Ting Chen

    04/03/2020, 5:26 PM
    I just joined the ZOOM. feel free to join when you are ready.
  • s

    Subbu Subramaniam

    04/03/2020, 5:35 PM
    ah ok, joining
  • s

    Subbu Subramaniam

    04/03/2020, 5:40 PM
    @User
  • t

    Ting Chen

    04/03/2020, 7:34 PM
    @User the segment fetcher based on ExternalView is here in the PR: https://github.com/apache/incubator-pinot/pull/4914/files#diff-39b1ee00ad2903f060a124b6fd49b5d5
    👍 1
  • t

    Ting Chen

    04/03/2020, 11:52 PM
    Just want to put a quick note from my side after today's discussion about the various smaller PRs to work on for this feature. Thanks for the inputs.
  • t

    Ting Chen

    04/03/2020, 11:52 PM
    1. New Server Rest End Point to download segments. 2. A new or refactored SegmentCommitter class to encapsulate commit policy and segment upload   * A new segment uploader class could be defined here too.   * This is probably the biggest change needed over the current PR and I will also need to look into the codes again. 3. PeerServerSegmentFetcher to download segment from peer servers if not found in deep store   * Use retries to handle EV update lag   4. Controller side changes 5. RealtimeValidationManager change to let servers to upload missing segments in deep store for last C (say 5) segments per partition.
  • s

    Subbu Subramaniam

    04/06/2020, 3:46 PM
    @User I have updated your PR 4914 with a comment on what I think should be the steps. Please take a look and let me know. If done in small increments, i can certainly help you get the feature in quickly. Be sure to get the architectural changes out in a discussion so that we dont have to discuss those in PRs (e.g. new uris, protocol changes, placement and naming of new config items, etc.). These are harder to change once implemented, so it is good to have a discussion on these items independent of a PR (your design doc is a great place)
  • t

    Ting Chen

    04/06/2020, 6:13 PM
    @User Thanks. Definitely small PRs will make things easier for review. I am going through your proposal now and they make sense. I will reply and work on breaking the POC into smaller ones.
  • s

    Subbu Subramaniam

    04/06/2020, 6:13 PM
    thanks , and i will promise timely reviews.
    👍 1
  • t

    Ting Chen

    04/06/2020, 10:22 PM
    @User I updated the https://github.com/apache/incubator-pinot/pull/4914 to clarify the steps you proposed earlier. I have some question about Step 5 on why it is needed and alternatives. The rest looks good to me. Working on step 1 right now.
  • t

    Ting Chen

    04/07/2020, 10:26 PM
    PR of the 1st change is ready for review: https://github.com/apache/incubator-pinot/pull/5221
  • t

    Ting Chen

    04/07/2020, 10:26 PM
    API changes proposal also sent out in mailing list and slack general channel.