@User I have already done that. thought of sharing this... for proper fix.

@User thanks

yes

@User even empty string also works

this should be fixed

@User Yeah we should have alignment that non mandatory field can be null so we should have null check for that.

@User Shall I create JIRA for this ?

it’s ok

no need for jira

yes, this field could be null and we should do null check for that

yes right

In latest master build "pinot-ingestion-job.sh" is not working because it expects main method in IngestionJobLauncher, which has been modified in latest build so either we should deprecate pinot-ingestion-job.sh or we should fix it. @User @User

ah true

@User

/usr/local/apache-pinot/bin/pinot-ingestion-job.sh /tmp/raw_data/order-batch-spec.yml
Error: Main method not found in class org.apache.pinot.spi.ingestion.batch.IngestionJobLauncher, please define the main method as:
   public static void main(String[] args)
or a JavaFX application class must extend javafx.application.Application

@User https://github.com/apache/incubator-pinot/pull/5403/files I have review comment please check that.

sure

also fixed the

pinot-ingestion-job.sh

great thanks @User

@User Are you planning to update IngestionJobLauncher.getSegmentGenerationJobSpec as mentioned in review comments ?

I dont see review comments

@User Could you please check now if you are able to see review comment ?

I replied

so it’s ok to putAll an empty map

it keeps propertiesMap the same

Sure, I was just thinking if map is empty then map.putAll will not do anything. But its fine if you are ok.

Do you want me to merge, or you will get it merge by some one else ?

i will merge once travis-ci passed

sure perfect thanks @User

@User has left the channel