Can the master branch still be built using Java 1....
# pinot-dev
k
Can the master branch still be built using Java 1.8? Just pulled and tried
mvn clean install -DskipTests -Pbin-dist -T 4 -Djdk.version=8
and got a strange error:
Copy code
[ERROR] pinot/pinot-common/src/test/java/org/apache/pinot/common/metrics/PinotMetricUtilsTest.java:[43,88] error: cannot access PinotMetricsRegistry
[ERROR]   class file for PinotMetricsRegistry not found
[ERROR] pinot/pinot-common/src/test/java/org/apache/pinot/common/metrics/PinotMetricUtilsTest.java:[77,76] error: incompatible types: PinotMetricsRegistry cannot be converted to org.apache.pinot.spi.metrics.PinotMetricsRegistry
[ERROR] pinot/pinot-common/src/test/java/org/apache/pinot/common/metrics/PinotMetricUtilsTest.java:[78,36] error: incompatible types: org.apache.pinot.spi.metrics.PinotMetricsRegistry cannot be converted to PinotMetricsRegistry
x
if CI passed then should be. Are you on openJDK 8?
k
No, Oracle 1.8. But feels like there might be a rebuild/stale dependencies issue hiding somewhere in the project…I set up a build with Java 11, and the first time it failed (in a different way than above), but the second time it worked fine. So I should try again with 1.8