https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v

    VoxBot

    07/13/2023, 7:56 PM
    \o/
  • v

    VoxBot

    07/13/2023, 7:56 PM
    The only CentOS 7 node I have host GitLab, for reasons… :-D
  • v

    VoxBot

    07/13/2023, 7:56 PM
    I really wanted not to drop it!
  • v

    VoxBot

    07/13/2023, 7:57 PM
    dreams about the day he will burn down this node…
  • s

    Slackbot

    07/13/2023, 9:04 PM
    This message was deleted.
    s
    d
    k
    • 4
    • 3
  • h

    Henry

    07/14/2023, 9:53 AM
    Can someone review: https://github.com/voxpupuli/puppet-systemd/pull/367 ? 🙂
  • y

    Yury Bushmelev

    07/14/2023, 11:50 AM
    ewoud: JFYI I realised my version of erb2epp has dropped every
    -
    in the
    -%>
    .. maybe you’ve spotted it already though
  • v

    VoxBot

    07/14/2023, 11:51 AM
    I didn't, but it'd be good to cover those things via more tests
  • v

    VoxBot

    07/14/2023, 11:51 AM
    I only added the project structure and verified it at least has some valid output, didn't analyze the file itself
  • y

    Yury Bushmelev

    07/14/2023, 11:51 AM
    either I broke it when switched from token reassembly to just collecting values.. or maybe it was like so before
  • y

    Yury Bushmelev

    07/14/2023, 11:51 AM
    I’ll have a look later then
  • v

    VoxBot

    07/14/2023, 11:55 AM
    ewoud: https://github.com/voxpupuli/puppet_metadata/pull/95
  • v

    VoxBot

    07/14/2023, 12:03 PM
    bastelfreak: thanks!
  • v

    VoxBot

    07/14/2023, 12:03 PM
    mhm now rspec fails
  • v

    VoxBot

    07/14/2023, 12:03 PM
    that passed before, didn't it
  • v

    VoxBot

    07/14/2023, 12:04 PM
    I thought it did, but it failed on RuboCop so perhaps it didn't?
  • v

    VoxBot

    07/14/2023, 12:04 PM
    https://github.com/voxpupuli/puppet_metadata/actions/runs/5455955479 it passed
  • v

    VoxBot

    07/14/2023, 12:04 PM
    or was that different code
  • v

    VoxBot

    07/14/2023, 12:04 PM
    quoting Zhenech: computers were a mistake?
  • v

    VoxBot

    07/14/2023, 12:07 PM
    now do we want archlinuxrolling-64.example.com or archlinuxrolling-64-none.example.com
  • v

    VoxBot

    07/14/2023, 12:08 PM
    I'd say the former
  • v

    VoxBot

    07/14/2023, 12:08 PM
    perfect
  • v

    VoxBot

    07/14/2023, 12:08 PM
    let me fix the tests
  • v

    VoxBot

    07/14/2023, 12:08 PM
    now I cant :D
  • v

    VoxBot

    07/14/2023, 12:09 PM
    did you revoke my push permissions
  • v

    VoxBot

    07/14/2023, 12:12 PM
    I did no such thing, you know how lazy I am ;)
  • v

    VoxBot

    07/14/2023, 12:14 PM
    mhm
  • v

    VoxBot

    07/14/2023, 12:15 PM
    https://github.com/voxpupuli/puppet_metadata/pull/91/checks lol, automerge merged it depite the failed checks
  • v

    VoxBot

    07/14/2023, 12:15 PM
    how's that possible
  • v

    VoxBot

    07/14/2023, 12:16 PM
    we probably don't have required tests set up, so automerge doesn't care
1...553554555...648Latest