Puppet Community

and why isn't there a simple string.split(',') â€¦

there's a join(array, optionalSeparator) but why no split function?

Hi,
I have a question about the systemd module, when I create a systemd unit with `systemd::manage_unit` is isn't allowed to set any limit parameter for example: `LimitNOFILE`, to set the limit I need to create the unit with `systemd::manage_unit`and then override it with a dropin file with `systemd::service_limits`  was this so intended? I think it would be prettier to have all Parameters in one unit

<https://github.com/voxpupuli/puppet-systemd/blob/master/manifests/manage_unit.pp#L112>
No Limits in the type:
<https://github.com/voxpupuli/puppet-systemd/blob/master/types/unit/service.pp>

All limits defined here:
<https://github.com/voxpupuli/puppet-systemd/blob/master/types/servicelimits.pp>
and only allowed in `systemd::service_limits`

I would like to create a PR but I'm not sure how to combine/merge the two types: `Systemd::ServiceLimits`
and `Systemd::Unit::Service` as resource parameter.
I tried something like:
`Optional[Variant[Systemd::Unit::Service,Systemd::ServiceLimits]] $service_entry = undef` but this doesn't work

```parameter 'service_entry' variant 0 expects an Undef value, got Struct
parameter 'service_entry' variant 1 unrecognized key 'LimitNOFILE'
parameter 'service_entry' variant 2 unrecognized key 'ExecStart```
usage:
```systemd::manage_unit { 'foobar.service':
    unit_entry    =&gt; {
        'Description' =&gt; 'foobar service',
    },
    service_entry =&gt; {
        'ExecStart'    =&gt; "/usr/sbin/foobar", # from Systemd::Unit::Service 
        'LimitNOFILE'  =&gt;  "65536", # from Systemd::ServiceLimits

    },
    install_entry =&gt; {
        'WantedBy' =&gt; 'multi-user.target',
    },
}```
When I understand correctly Variant is like an `or`, but because `ExecStart` is defined in `Systemd::Unit::Service` and `LimitNOFILE` is defined in `Systemd::ServiceLimits` none of these matches for the complete hash.
Need something like: `Optional[Systemd::Unit::Service + Systemd::ServiceLimits] $service_entry = undef`

I think you just need to add $limit_entry attribute instead

hmm, I'm not sure I agree with <https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/TernaryParentheses>

why is bar &amp;&amp; baz ? a : b better than (bar &amp;&amp; baz) ? a : b

I'm leaning more to EnforcedStyle: require_parentheses_when_complex

any construct where you need to think hard about the precedence order or operators is... not good IMO

<https://github.com/voxpupuli/voxpupuli-rubocop/pull/30>

can I get a review for <https://github.com/voxpupuli/voxpupuli-rubocop/pull/31>

<https://github.com/voxpupuli/rspec-puppet-facts/pull/151> should we pull the trigger and merge this?

I've been thinking about expanding the README on how the facter version is interpreted, but given it's set by the library itself via the JSON I wonder how much that helps

at this point I wonder how much of a major version it really is, but we can discuss that later

can I get a review for <https://github.com/voxpupuli/puppet-keepalived/pull/292>

\o/ I managed to fix the failing CI for gitlab_ci_runner: <https://github.com/voxpupuli/puppet-gitlab_ci_runner/pull/171> \o/