# voxpupuli
- v
VoxBot
07/14/2023, 12:16 PMwe do have it set up - v
VoxBot
07/14/2023, 12:16 PMwell, today it gave you a big fat middle finger - v
VoxBot
07/14/2023, 12:17 PMhttps://github.com/voxpupuli/puppet_metadata/pull/96 also lists it as required check - y
Yury Bushmelev
07/14/2023, 12:22 PMdo we have automerger enabled? 🤔 - v
VoxBot
07/14/2023, 12:22 PMno - v
VoxBot
07/14/2023, 12:23 PMwell not for the whole org - y
Yury Bushmelev
07/14/2023, 12:23 PMmagic - v
VoxBot
07/14/2023, 12:23 PMon PRs with a required check you can enable automerge for a single PR - y
Yury Bushmelev
07/14/2023, 12:23 PMah, I see - y
Yury Bushmelev
07/14/2023, 12:24 PMhm.. I forgot how annoying animated sticker can be.. - y
Yury Bushmelev
07/14/2023, 12:45 PMwell.. I guess 3x less
than in ERB version is good enough for ERB -> EPP migration 🙂\n - y
Yury Bushmelev
07/14/2023, 12:46 PMthough.. maybe I can go for exact the same result.. - y
Yury Bushmelev
07/14/2023, 5:50 PMhmm.. I just hit some magic.. I have this in a EPP template:Copy code
$raw_append is an Array. If I pass<%- $raw_append.each |$line| { -%> <%= $line %> <%- } -%>
as a $raw_append it adds an empty line. But if I replace $raw_append to[]
right in the EPP it doesn’t 🤔[] - y
Yury Bushmelev
07/14/2023, 5:50 PM(
I mean)<%- [].each |$line| { -%> - y
Yury Bushmelev
07/14/2023, 5:55 PMit seems there is
actually..[ undef ] - y
Yury Bushmelev
07/14/2023, 6:00 PMyep.. $raw_append.length is 1 - y
Yury Bushmelev
07/14/2023, 6:02 PMok,
solved thisfilter - s
smortex
07/14/2023, 6:02 PMData types could help avoid this… but that is a lot of work 🙂 - s
smortex
07/14/2023, 6:02 PM"avoid"… I mean "alert" 🙃 - y
Yury Bushmelev
07/14/2023, 6:02 PMit was me who did it actually.. I tried to make it Array always with [$raw_append].flatten - y
Yury Bushmelev
07/14/2023, 6:03 PMbut if it’s $raw_append is Undef then.. - y
Yury Bushmelev
07/14/2023, 6:03 PMOriginal definition isOptional[Variant[Array, String]] $raw_append = undef, - s
smortex
07/14/2023, 6:03 PMSmells like aVariant[String, Array[String]] - s
smortex
07/14/2023, 6:03 PMah ! - y
Yury Bushmelev
07/14/2023, 6:04 PM💯 - s
smortex
07/14/2023, 6:04 PM
is how I handle this to avoid to much hack in the templatesArray[String] $foo = [] - v
VoxBot
07/14/2023, 6:04 PMI always try to avoid flatten when I can - v
VoxBot
07/14/2023, 6:04 PMand with EPP you can use data types to enforce that safely - y
Yury Bushmelev
07/14/2023, 6:05 PM@smortex but what to do with a lot of legacy configs where it’s String actually? 🙂 - v
VoxBot
07/14/2023, 6:05 PMand I also prefer the empty array when possible