https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v

    VoxBot

    03/17/2023, 8:38 PM
    I'm leaning to 1.4.1 instead of 1.5.0 for it
  • v

    VoxBot

    03/17/2023, 8:39 PM
    I'm fine with 1.4.1
  • v

    VoxBot

    03/17/2023, 8:39 PM
    do you want to merge the PR from Yury as well?
  • v

    VoxBot

    03/17/2023, 8:39 PM
    https://github.com/voxpupuli/beaker-docker/pull/75 this one
  • v

    VoxBot

    03/17/2023, 8:39 PM
    I kind of broke that with a merge conflict :(
  • b

    bastelfreak

    03/17/2023, 8:40 PM
    @Yury Bushmelev can probably do a quick rebase when we ask him nicely
  • v

    VoxBot

    03/17/2023, 8:40 PM
    speaking of the Rakefile for beaker: I wonder about the docs tasks: there must be a better way
  • v

    VoxBot

    03/17/2023, 8:41 PM
    ewoud: are they even used?
  • v

    VoxBot

    03/17/2023, 8:41 PM
    the rake tasks I mean
  • v

    VoxBot

    03/17/2023, 8:41 PM
    bastelfreak: technically you could generate the docs I suppose, but I wonder how many people use those
  • v

    VoxBot

    03/17/2023, 8:41 PM
    yeah
  • v

    VoxBot

    03/17/2023, 8:42 PM
    I think we should aim for rubydoc.info, not the rake task
  • v

    VoxBot

    03/17/2023, 8:42 PM
    and no, they're not even used since we don't include yard in our Gemfile
  • v

    VoxBot

    03/17/2023, 8:42 PM
    so they're just busted
  • v

    VoxBot

    03/17/2023, 8:42 PM
    https://rubydoc.info/github/puppetlabs/beaker nice
  • v

    VoxBot

    03/17/2023, 8:43 PM
    https://rubydoc.info/gems/beaker ah better
  • y

    Yury Bushmelev

    03/17/2023, 8:53 PM
    I’ll rebase tomorrow, np
  • v

    VoxBot

    03/17/2023, 8:54 PM
    thanks!
  • v

    VoxBot

    03/17/2023, 8:58 PM
    bastelfreak: well, maybe let's just make it a .y release: I've rebased https://github.com/voxpupuli/beaker-docker/pull/73 to run all tests again
  • v

    VoxBot

    03/17/2023, 9:01 PM
    https://github.com/fakefs/fakefs/commit/b10c593f341ef08c0b36af3d521bcb1e82badb2b really weird reason to make it 2.0.0 and not in 1.9.0, but okay …
  • v

    VoxBot

    03/17/2023, 9:11 PM
    bastelfreak: https://github.com/voxpupuli/beaker-docker/pull/98
  • v

    VoxBot

    03/17/2023, 9:16 PM
    done
  • v

    VoxBot

    03/17/2023, 9:18 PM
    ewoud: if you do a release today, can you add the minimal ruby verison to the gemspec?
  • v

    VoxBot

    03/17/2023, 9:20 PM
    (I switched to smartphone and cant submit code)
  • v

    VoxBot

    03/17/2023, 9:26 PM
    something like https://github.com/voxpupuli/beaker-docker/pull/99
  • v

    VoxBot

    03/17/2023, 9:58 PM
    bastelfreak: https://github.com/voxpupuli/beaker-docker/pull/100 small one
  • y

    Yury Bushmelev

    03/18/2023, 7:14 AM
    Well.. I rebased my PR: https://github.com/voxpupuli/beaker-docker/pull/75.. but not it fails on
    rspec/its
    missing.. as I see
    spec_helper
    includes beaker who uses
    rspec/its
    .. 🤔
  • y

    Yury Bushmelev

    03/18/2023, 7:14 AM
    Well.. I rebased my PR: https://github.com/voxpupuli/beaker-docker/pull/75.. but not it fails on
    rspec/its
    missing.. as I see
    spec_helper
    includes beaker who uses
    rspec/its
    .. 🤔
  • y

    Yury Bushmelev

    03/18/2023, 7:21 AM
    it’s from here: https://github.com/voxpupuli/beaker/blob/master/spec/spec_helper.rb#L30
  • y

    Yury Bushmelev

    03/18/2023, 7:21 AM
    it’s from here: https://github.com/voxpupuli/beaker/blob/master/spec/spec_helper.rb#L30
1...373374375...648Latest