https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • y
    not sure why it’s not installed as dependency of 
    beaker
    gem..
  • y
    Ah.. it’s the dev dependency..
  • y
    well.. gtg now.. let me know what is better way to get out of this.. I’d either drop 
    rspec/its
    from everywhere or add it back as dev dependency to the 
    beaker-docker
  • y
    Easy fix is to add 
    s.add_development_dependency 'rspec-its'
    to the gemspec. Just tested it and it works fine.
  • v
    I just dropped that, and the tests passed
  • v
    I think you maybe missed something in the rebase?
  • y
    Copy code
    An error occurred while loading ./spec/beaker/hypervisor/docker_spec.rb.
Failure/Error: require File.join(beaker_spec_path, 'spec_helper.rb')

LoadError:
  cannot load such file -- rspec/its
  • y
    here I see the 
    rspec/its
    is loaded by 
    beaker
    itself (I pasted the github link above)
  • y
    not sure what I missed..
  • y
    let me try with master branch though
  • y
    hm.. master is fine 🤔
  • y
    well.. I found the problem I think.. it’s because I dropped the Gemfile.local which includes the 
    beaker-rspec
  • y
    so it works with 
    rspec-its
    replaced with 
    beaker-rspec
    in gemspec
  • y
    well.. I found that 
    its
    was removed from RSpec v3.. and 
    beaker
    uses it just in 
    logger_spec.rb
    .. maybe I can rewrite it to use modern syntax and drop the 
    rspec-its
    completely
  • y
    ok, I’ll return the Gemfile.local for the moment then.. easiest way
  • y
    looks good now
  • v
  • y
    \o/
  • c
    is puppet-blacksmith part of the vox toolchain?
  • s
    This message was deleted.
    c
    • 2
    • 2
  • s
    This message was deleted.
    c
    b
    • 3
    • 5
  • b
    @Craig Gumbley I digged through https://github.com/puppetlabs/puppetlabs-postgresql/blob/main/.github/workflows/release.yml#L22 and noticed that your action to create github releases isn't maintained anymore: https://github.com/actions/create-release
  • v
    ewoud: when time permits, I would like to create a shared workflow for gem testing. the gha-puppet repo name doesn't fit. We could rename that or create a second repo, maybe gha-gems? Do you have opinions? I think I prefer another repo
  • v
    and if someone wants to review some PRs, I've https://github.com/orgs/voxpupuli/projects/4 ready
  • v
    bastelfreak: +1 for another repo
  • v
    nods
  • v
    bastelfreak: though I'd also consider a workflow in beaker itself and use that from the various beaker gems
  • v
    I haven't fully thought it through, but just a thought
  • v
    I had the same thought for beaker and puppet-lint for rubocop and CI workflow
  • m
    heyho dear humans - I have added a basic module for opensearch at https://github.com/voxpupuli/puppet-opensearch - it is really basic - and there are still some example missing - also the readme is still the one from pdk init.
1...374375376...648Latest