https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • a
    The only code change I made whilst in there was to remove some 
    validate_
    functions. eg. https://github.com/voxpupuli/puppet-varnish/pull/12/files#diff-1bc4e5692ece2b3ab3fde3dacf7619481f95c1fffd8966fc133c1f6c4cf40acbL119
  • a
    The datatypes cover all of these, so they're redundant.
  • a
    Where the doc strings mentioned a default, I removed those as puppet-strings will work this out automatically and you only want a single source of truth.
  • a
    I could probably find a bunch more things to tweak, but that's plenty for one PR.
  • v
    how would you move manifests/vcl/includefile.pp to vcl.pp?
  • a
    With some iteration (that probably didn't exist when the module was first written)
  • v
    ok, will have a look at that ..
  • a
    As I see it, it's private to 
    vcl.pp
    and the create_resources stuff in that class (which could also be refactored), depends on that type having be included once per 'thing'
  • v
    jup, thats the case... but thats also very old code thats still working ;) so something to refacor
  • v
    should I merge those PR or anybody of you?
  • a
    I mean that's the idea behind me saying it could be moved into the vcl class anyway. It's a shame it's not 100% consistently a perfect mapping.
  • a
  • a
  • v
    backendselection contains selectors...
  • v
    naming is not 100% perfect here... true..
  • v
    are you normally adding some kind of tests of the actual results? For example if the resulting VCL compiles with varnish 6 here
  • a
    I’m not a subject matter expert, but perhaps you can verify config files with https://github.com/puppetlabs/puppetlabs-concat/blob/main/REFERENCE.md#-concat--validate_cmd ?
  • a
    Maybe that’s not going to work though unless all the config were to be written to a single file.
  • a
    If you want to write tests, you could look at adding some beaker based acceptance tests.
  • v
    morning
  • v
    acceptance tests for the k8s module would be awesome
    👍 2
  • v
    voxpupuli-test 5.6 is out which uses voxpupuli-puppet-lint-plugins 4 which uses puppet-lint 3.2 \o/
  • b
    @Craig Gumbley ^
    ❤️ 1
  • v
    The k8s module still needs to have a bunch of documentation written, and some unfinished areas need to be properly marked as such as well
  • v
    Ananace: o/
  • v
    it's doing k8s, is there anything ever finished in that area? :D
  • v
    :D
  • v
    Well, I don't see them moving away from YAML any time soon, so the markup language choice is probably finished
  • v

    https://media4.giphy.com/media/Ow59c0pwTPruU/giphy.gif▾

  • v
    Really feels like there should be some kind of Ensure type in stdlib
    👍 1
1...336337338...648Latest