https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v

    VoxBot

    02/28/2023, 7:09 PM
    https://github.com/voxpupuli/puppet-varnish/pull/8
  • a

    Alex Fisher

    02/28/2023, 7:09 PM
    Some of the puppet-strings stuff could do with a cleanup too. There's lots of stray output in https://github.com/voxpupuli/puppet-varnish/blob/release-3.0.0/REFERENCE.md
  • a

    Alex Fisher

    02/28/2023, 7:09 PM
    Some of the puppet-strings stuff could do with a cleanup too. There's lots of stray output in https://github.com/voxpupuli/puppet-varnish/blob/release-3.0.0/REFERENCE.md
  • a

    Alex Fisher

    02/28/2023, 7:11 PM
    now feels guilty and will lend a hand
  • a

    Alex Fisher

    02/28/2023, 7:12 PM
    I've got to head out to the airport soon(ish) to do a pickup though. Let's see how much I can get done in 20 minutes or so.
  • v

    VoxBot

    02/28/2023, 7:13 PM
    https://github.com/voxpupuli/puppet-varnish/pull/9
  • v

    VoxBot

    02/28/2023, 7:14 PM
    should I remove almost all of the Reference stuff from Readme, as it is more or less a manual copy of REFERENCE.md
  • v

    VoxBot

    02/28/2023, 7:14 PM
    ?
  • v

    VoxBot

    02/28/2023, 7:15 PM
    in my opinion, yes. It's nice if the README.md has some examples on how to use the module and mention that all parameters are documented in the REFERENCE.md, but it's not required to duplicate the information
  • v

    VoxBot

    02/28/2023, 7:37 PM
    https://github.com/voxpupuli/puppet-varnish/pull/10
  • v

    VoxBot

    02/28/2023, 7:39 PM
    https://github.com/voxpupuli/puppet-varnish/pull/11
  • v

    VoxBot

    02/28/2023, 7:44 PM
    Is there one recommended license for the module or just leave it as it is?
  • v

    VoxBot

    02/28/2023, 7:44 PM
    only requirement we have is that is has to have any open source license
  • v

    VoxBot

    02/28/2023, 7:45 PM
    apache-2 is valid. changing the license usually requires approval from all contributors. that... takes time :D
  • v

    VoxBot

    02/28/2023, 7:45 PM
    so since it's already apache-2, you can keep that
  • v

    VoxBot

    02/28/2023, 7:45 PM
    (my personal preference is agpl-3)
  • a

    Alex Fisher

    02/28/2023, 7:46 PM
    yeah, but that's a rubbish choice.
  • a

    Alex Fisher

    02/28/2023, 7:46 PM
    ducks
  • a

    Alex Fisher

    02/28/2023, 7:46 PM
    😉
  • v

    VoxBot

    02/28/2023, 7:46 PM
    ok, than we'll leave that..
  • a

    Alex Fisher

    02/28/2023, 7:47 PM
    I've got a puppet-strings update PR incoming. Give me 5 more minutes to check the output
  • v

    VoxBot

    02/28/2023, 7:47 PM
    great ... ty
  • a

    Alex Fisher

    02/28/2023, 7:51 PM
    https://github.com/voxpupuli/puppet-varnish/pull/12
  • a

    Alex Fisher

    02/28/2023, 7:51 PM
    https://github.com/voxpupuli/puppet-varnish/pull/12
  • a

    Alex Fisher

    02/28/2023, 7:52 PM
    Not perfect, but it at least renders a bit better now.
  • v

    VoxBot

    02/28/2023, 7:56 PM
    puh.... quite a lot changes ;)
  • a

    Alex Fisher

    02/28/2023, 7:57 PM
    Mostly to bring stuff in line with https://www.puppet.com/docs/puppet/5.5/puppet_strings_style.html
  • v

    VoxBot

    02/28/2023, 7:58 PM
    invested quite a lot time to insert those and shows me how i failed :D
  • a

    Alex Fisher

    02/28/2023, 7:59 PM
    It didn't take too long to straighten out.
  • v

    VoxBot

    02/28/2023, 8:01 PM
    when i started there was almost nothing...
1...335336337...648Latest