# voxpupuli
- a
Alex Fisher
02/28/2023, 6:52 PMLooks like there's a bit more cleanup you might want to do before a release. - a
Alex Fisher
02/28/2023, 6:52 PM - a
Alex Fisher
02/28/2023, 6:52 PM - a
Alex Fisher
02/28/2023, 6:54 PMand a quick tidy up of the README - a
Alex Fisher
02/28/2023, 6:54 PMeg. fix/remove this https://github.com/voxpupuli/puppet-varnish#development - a
Alex Fisher
02/28/2023, 6:54 PMadd syntax highlighting to the code blocks - v
VoxBot
02/28/2023, 6:54 PMbastelfreak: summary worked now - a
Alex Fisher
02/28/2023, 6:55 PMFix the markdown for the ToC header - a
Alex Fisher
02/28/2023, 6:55 PMAdd some badges? - v
VoxBot
02/28/2023, 6:56 PMhttps://raw.githubusercontent.com/voxpupuli/puppet-openssl/master/README.md this is a good place to copy the badges - a
Alex Fisher
02/28/2023, 6:58 PMhttps://github.com/voxpupuli/puppet-varnish#tests is probably not accurate anymore either. - v
VoxBot
02/28/2023, 6:59 PMso I'll look at the Readme... nuke Modulefile? what do you mean? - a
Alex Fisher
02/28/2023, 7:00 PMIsn't that a really old thing that metadata.json replaced a long time ago? - a
Alex Fisher
02/28/2023, 7:00 PMhttps://github.com/voxpupuli/puppet-varnish/blob/master/.sync.yml also looks like it should go as vox modules use modulesync and not pdk?? - v
VoxBot
02/28/2023, 7:00 PMah yeah.. could be - a
Alex Fisher
02/28/2023, 7:00 PMhttps://github.com/voxpupuli/puppet-varnish/blob/master/.sync.yml also looks like it should go as vox modules use modulesync and not pdk?? - a
Alex Fisher
02/28/2023, 7:01 PMwhat else... Dunno what https://github.com/voxpupuli/puppet-varnish/blob/master/.mailmap is for - a
Alex Fisher
02/28/2023, 7:01 PMwhat else... Dunno what https://github.com/voxpupuli/puppet-varnish/blob/master/.mailmap is for - a
Alex Fisher
02/28/2023, 7:02 PM - a
Alex Fisher
02/28/2023, 7:02 PM - a
Alex Fisher
02/28/2023, 7:04 PMhttps://github.com/voxpupuli/puppet-varnish/blob/master/.fixtures.yml#L3-L15 can probably be simplified now that we're only testing on puppet 6 and above. I think @bastelfreak did some similar tidy ups in some other modules recently. - a
Alex Fisher
02/28/2023, 7:04 PMhttps://github.com/voxpupuli/puppet-varnish/blob/master/.fixtures.yml#L3-L15 can probably be simplified now that we're only testing on puppet 6 and above. I think @bastelfreak did some similar tidy ups in some other modules recently. - v
VoxBot
02/28/2023, 7:04 PMisn't .mailmap used to map different email addresses to git(hub) accounts? - a
Alex Fisher
02/28/2023, 7:04 PMThese 2 lines are redundant. https://github.com/voxpupuli/puppet-varnish/blob/master/.fixtures.yml#L3-L15 - a
Alex Fisher
02/28/2023, 7:04 PMThese 2 lines are redundant. https://github.com/voxpupuli/puppet-varnish/blob/master/.fixtures.yml#L3-L15 - v
VoxBot
02/28/2023, 7:05 PMI can provide a PR for .fixtures.yml - a
Alex Fisher
02/28/2023, 7:05 PMmaybe?? I'm suspicious of random 9 year old files! ;) - v
VoxBot
02/28/2023, 7:06 PMI'll focus on README for now.. - v
VoxBot
02/28/2023, 7:06 PMty - a
Alex Fisher
02/28/2023, 7:07 PMGreat. Most of these are quick wins.