https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • j

    jhoblitt

    01/26/2023, 10:35 PM
    it seems to be closer to 1s where I've tested. That seems like alot
  • j

    jhoblitt

    01/26/2023, 10:35 PM
    it seems to be closer to 1s where I've tested. That seems like alot
  • j

    jhoblitt

    01/26/2023, 10:38 PM
    Copy code
    Offenses:
    
    spec/unit/facter/udev_spec.rb:84:27: C: [Correctable] Layout/SpaceAroundOperators: Operator => should be surrounded by a single space. (<https://rubystyle.guide#spaces-operators>)
                  'property'  => include(
                              ^^
  • j

    jhoblitt

    01/26/2023, 10:38 PM
    Copy code
    Offenses:
    
    spec/unit/facter/udev_spec.rb:84:15: C: Layout/HashAlignment: Align the keys and values of a hash literal if they span more than one line.
                  'property' => include( ...
                  ^^^^^^^^^^^^^^^^^^^^^^
    
    40 files inspected, 1 offense detected
  • j

    jhoblitt

    01/26/2023, 10:38 PM
    thanks rubocop
  • b

    bastelfreak

    01/26/2023, 10:41 PM
    the autofix option is great
  • j

    jhoblitt

    01/26/2023, 10:41 PM
    that is the autofix
  • j

    jhoblitt

    01/26/2023, 10:42 PM
    it just oscillates.
  • b

    bastelfreak

    01/26/2023, 10:42 PM
    ah :D
  • j

    jhoblitt

    01/26/2023, 10:42 PM
    sorry, that output was without autofix... but that is what it is doing
  • j

    jhoblitt

    01/26/2023, 10:42 PM
    no idea why it is upset about this one hash one the dozens of others in the same file don't do this
  • j

    jhoblitt

    01/26/2023, 10:42 PM
    I've tried to organizing the keys several ways
  • j

    jhoblitt

    01/26/2023, 10:43 PM
    looks like a parser bug as the hash it is upset about now only started after I added a hash above it
  • j

    jhoblitt

    01/26/2023, 10:45 PM
    gezbuz, finally find a hash key order to makes it happy
  • j

    jhoblitt

    01/26/2023, 10:50 PM
    @bastelfreak do you want to take another look at https://github.com/voxpupuli/puppet-systemd/pull/292 ? Most of the changes I've made are to the unit tests.
  • j

    jhoblitt

    01/26/2023, 10:50 PM
    @bastelfreak do you want to take another look at https://github.com/voxpupuli/puppet-systemd/pull/292 ? Most of the changes I've made are to the unit tests.
  • j

    jhoblitt

    01/26/2023, 10:51 PM
    oh, need to remove a the caveat on the fact... that's no longer true
  • j

    jhoblitt

    01/26/2023, 10:59 PM
    @bastelfreak Do you mean confining on the existence of the file
    /usr/bin/udevadm
    ? I thought there was no guarantee that would be the path.
  • j

    jhoblitt

    01/26/2023, 11:00 PM
    I've been bitten by debian having separate /bin /usr/bin in the past
  • j

    jhoblitt

    01/26/2023, 11:00 PM
    I've been bitten by debian having separate /bin /usr/bin in the past
  • j

    jhoblitt

    01/26/2023, 11:07 PM
    huh. First time I've seen this happen:
    Copy code
    -- Add support for strict mode for DNS over TLS [\#200](<https://github.com/voxpupuli/puppet-systemd/pull/200>) ([wobblesprout](<https://github.com/wobblesprout))>
    +- Add support for strict mode for DNS over TLS [\#200](<https://github.com/voxpupuli/puppet-systemd/pull/200>) ([ghost](<https://github.com/ghost))>
  • d

    Dr Bunsen Honeydew

    01/26/2023, 11:07 PM
    ``` took a hit! Ouch. (Karma: -2)
    clapping 1
  • j

    jhoblitt

    01/26/2023, 11:10 PM
    @Simon Deziel FYI - https://github.com/voxpupuli/puppet-systemd/pull/312
  • j

    jhoblitt

    01/26/2023, 11:10 PM
    @Simon Deziel FYI - https://github.com/voxpupuli/puppet-systemd/pull/312
  • s

    Slackbot

    01/26/2023, 11:55 PM
    This message was deleted.
    b
    j
    +3
    • 6
    • 49
  • s

    Slackbot

    01/27/2023, 8:02 AM
    This message was deleted.
    j
    • 2
    • 1
  • v

    VoxBot

    01/27/2023, 10:57 AM
    bleh, with puppet-systemd 4 we broke some modules :(
  • d

    Dr Bunsen Honeydew

    01/27/2023, 10:57 AM
    See the
    puppet-systemd
    module at https://forge.puppet.com/puppet/systemd?src=slack&amp;channel=voxpupuli
  • v

    VoxBot

    01/27/2023, 10:57 AM
    like puppet-redis
  • d

    Dr Bunsen Honeydew

    01/27/2023, 10:58 AM
    See the
    puppet-redis
    module at https://forge.puppet.com/puppet/redis?src=slack&amp;channel=voxpupuli
1...260261262...648Latest