https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v

    VoxBot

    01/27/2023, 10:58 AM
    how do we deal with this? the removal of restart_service parameter means it's hard to be compatible with both, but requiring the new major is also painful
  • v

    VoxBot

    01/27/2023, 11:04 AM
    and we don't depend on extlib so it's not that we can inspect the metadata
  • v

    VoxBot

    01/27/2023, 11:16 AM
    so it's https://github.com/voxpupuli/puppet-redis/blob/f429c7656b06078f6921c5faff674aa6291deaff/manifests/instance.pp#L467 and it's incompatible to drop it
  • s

    Slackbot

    01/27/2023, 11:16 AM
    This message was deleted.
    j
    • 2
    • 1
  • v

    VoxBot

    01/27/2023, 11:27 AM
    https://github.com/voxpupuli/puppet-systemd/pull/313
  • v

    VoxBot

    01/27/2023, 12:00 PM
    ah mhm
  • v

    VoxBot

    01/27/2023, 12:06 PM
    ewoud: why cant we remove the restart_service => false in puppet-redis?
  • d

    Dr Bunsen Honeydew

    01/27/2023, 12:06 PM
    See the
    puppet-redis
    module at https://forge.puppet.com/puppet/redis?src=slack&channel=voxpupuli
  • v

    VoxBot

    01/27/2023, 12:07 PM
    then it would try to restart redis? doesn't that work or don't we want that?
  • v

    VoxBot

    01/27/2023, 12:10 PM
    I wouldn't want that
  • v

    VoxBot

    01/27/2023, 12:10 PM
    two service restarts is bad IMHO
  • v

    VoxBot

    01/27/2023, 12:10 PM
    okay
  • v

    VoxBot

    01/27/2023, 12:11 PM
    geting some circular dependencies with new systemd - good chance its rubbish our side -- investigating...
  • v

    VoxBot

    01/27/2023, 12:24 PM
    ewoud: should we maybe add a note to the param to remove with with the 5.0 release?
  • v

    VoxBot

    01/27/2023, 12:24 PM
    perhaps an issue with a 5.0 milestone? or a PR already with backwards-incompatible?
  • v

    VoxBot

    01/27/2023, 12:25 PM
    I think a PR is good
  • v

    VoxBot

    01/27/2023, 12:26 PM
    approved #313. I think you can go on an merge & create a release PR
  • v

    VoxBot

    01/27/2023, 12:36 PM
    oh bah, I just noticed that 4.0.0 was never pushed to our repo
  • v

    VoxBot

    01/27/2023, 12:37 PM
    ah, so it never made it into a release yet, it's just that I was testing with git master
  • v

    VoxBot

    01/27/2023, 12:37 PM
    good morning everyone :D
  • v

    VoxBot

    01/27/2023, 12:38 PM
    well, that saves me making a release
  • v

    VoxBot

    01/27/2023, 12:40 PM
    ah perfect :D
  • v

    VoxBot

    01/27/2023, 12:40 PM
    I wanted to work on my cfgmgmtcamp talk today
  • v

    VoxBot

    01/27/2023, 12:40 PM
    and a few minutes later I saw a tweet advertising the talk
  • v

    VoxBot

    01/27/2023, 12:40 PM
    same, but I've wanted to do that for a week or so and have yet to start with slides
  • v

    VoxBot

    01/27/2023, 12:41 PM
    https://twitter.com/cfgmgmtcamp/status/1618896596254482435 turns out thats your talk not mine :D
  • v

    VoxBot

    01/27/2023, 12:41 PM
    no pressure to start on slides :P
  • v

    VoxBot

    01/27/2023, 12:41 PM
    :D
  • v

    VoxBot

    01/27/2023, 12:42 PM
    There's probably something in https://github.com/bastelfreak/talks that roughly matches
  • v

    VoxBot

    01/27/2023, 12:42 PM
    I should start to organize my talks a bit more
1...261262263...648Latest