https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • j
    @ewoud are you going to rebase https://github.com/voxpupuli/puppet-systemd/pull/194 as well?
  • j
    @ewoud are you going to rebase https://github.com/voxpupuli/puppet-systemd/pull/194 as well?
  • v
    literally typing now :P
    🙏 1
  • p
    While you're in the area, any thoughts on https://github.com/voxpupuli/puppet-systemd/pull/197 ?
  • p
    While you're in the area, any thoughts on https://github.com/voxpupuli/puppet-systemd/pull/197 ?
  • j
    @Pat Riehecky I'm honestly under the weather today and trying to avoid having deep thoughts. I think that PR looks reasonable but I could also see how it might be too much magic.
  • p
    It's sat for a few years now, it can sit longer
  • v
    bleh, dpendency cycles when I rebase it
  • v
    I'll revisit it later
  • j
    @ewoud if you approve my EOL OS PRs it will cut down on the gha runtime 😉
  • j
    @ewoud I'm going to close https://github.com/voxpupuli/puppet-systemd/issues/5 as it isn't relevant. Not sure what label to put on it.
  • j
    @ewoud I'm going to close https://github.com/voxpupuli/puppet-systemd/issues/5 as it isn't relevant. Not sure what label to put on it.
  • v
    I think this is fine
  • j
    I'll put skip-changelog on it too
  • s
    @jhoblitt could you drop the backward incompatible label on https://github.com/voxpupuli/puppet-systemd/pull/278 please?
  • s
    @jhoblitt could you drop the backward incompatible label on https://github.com/voxpupuli/puppet-systemd/pull/278 please?
  • s
    unless that label is purely informative
  • j
    @Simon Deziel It isn't necessary in this case. We add the label when dropping support but adding support for a new OS in and of itself isn't a breaking change.
  • j
    oh, sorry, you said drop
  • j
    yes of course
    👍 1
  • j
    merged
  • j
    off my game today...
  • j
    @Simon Deziel Sorry for the confusion there. Did everything you need get merged?
  • s
    @jhoblitt yep, all good now, thanks! I'm currently testing the changes to see if all's good
  • s
    This message was deleted.
    s
    • 2
    • 1
  • j
  • j
    I'm planning on making a new release once https://github.com/voxpupuli/puppet-systemd/pull/292 goes in. Hopefully, that will be ready today
  • j
    I'm planning on making a new release once https://github.com/voxpupuli/puppet-systemd/pull/292 goes in. Hopefully, that will be ready today
  • j
    I'm slightly concerned about the runtime cost of that fact
  • b
    worked in a fraction of a second here
1...259260261...648Latest