@Jethro yes, mongo isnt executed in the unit tests. But we also have acceptance tests, they execute the puppet code in docker containers

thanks

@bastelfreak is this a solution for the rspec nil output? https://github.com/voxpupuli/puppet-mongodb/pull/662/files#diff-a589b8233f76fc6386e2f6bf77448f1793f582292eb7257fb3b414d0d57094eeR109 at least all test are okay now.

I'd say it's not a good thing to do - if you mock/stub mongo_eval you should tell it to return something

so you have that on line 100/101 and you can add .that_returns('...')

Thanks for the tip but I get:

#12 185.1   1) Puppet::Type::Mongodb_user::ProviderMongodb password_hash= changes a password_hash
#12 185.1      Failure/Error:
#12 185.1        allow(provider).to receive(:mongo_eval).
#12 185.1          with("db.runCommand(#{cmd_json})", 'new_database').that_returns('{"ok": 1}')
#12 185.1 
#12 185.1      NoMethodError:
#12 185.1        undefined method `that_returns' for #<RSpec::Mocks::Matchers::Receive:0x0000563393d80758>
#12 185.1      # ./spec/unit/puppet/provider/mongodb_user/mongodb_spec.rb:101:in `block (3 levels) in <top (required)>'

Thanks for the tip but I get:

#12 185.1   1) Puppet::Type::Mongodb_user::ProviderMongodb password_hash= changes a password_hash
#12 185.1      Failure/Error:
#12 185.1        allow(provider).to receive(:mongo_eval).
#12 185.1          with("db.runCommand(#{cmd_json})", 'new_database').that_returns('{"ok": 1}')
#12 185.1 
#12 185.1      NoMethodError:
#12 185.1        undefined method `that_returns' for #<RSpec::Mocks::Matchers::Receive:0x0000563393d80758>
#12 185.1      # ./spec/unit/puppet/provider/mongodb_user/mongodb_spec.rb:101:in `block (3 levels) in <top (required)>'

oh yes, it's and_return

that_returns is mocha

aha thanks! That works! Let me see if i can add a test that catch the failure also so both situations are being tested.

This message was deleted.

Are we considering SLES12 still supported? https://www.suse.com/lifecycle/ claims that "SUSE Linux Enterprise High Availability Extension 12 SP5" has support until 2027

I am not a SLES user so I'm not sure exactly where we draw the line

I kind of think so, but I don't know people who use SLES

why?

I'm cleanup puppet-systemd's metadata.json and it claims SLES12 support

See the

puppet-systemd

module at https://forge.puppet.com/puppet/systemd?src=slack&channel=voxpupuli

if sles/suse would just die...

if we're doing breaking changes there, let me rebase my breaking change PRs

we are always doing breaking changes...

it is the way of things

they have vagrant/container images, but not public on dockerhub

debian 8 CI is hosed...

well yes, Debian 8 is removed from Debian mirrors

ya... so I have to deal with it. I'm willing to do a new release of systemd as well after the udev fact is merged.

yikes. So SuSE owns Rancher Labs. That might take a minute to die.

as I commented on one of the PRs, I really think we should be dropping OS support in a dedicated PR so it shows up clearly in the generated changelog

AND it has an SAP specific offering, tuned to supporting SAP Applications

This message was deleted.