https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • c
    Yeah its not ideal. It was chosen to keep it inline with the rest of the stuff we have.
  • c
    It’s something we want to bump across the board though
  • b
    but does that make sense? the majority of the rest supports older ruby versions?
  • b
    for example we rely on rubocop 1.22.x for stuff that runs on ruby 2.5, other projects pull in newer rubocop
  • v
    IIRC 1.22.x also provides the --progress github option which gives you GH annotations for failed lints
  • c
    The annotations were in your PR which is interesting
  • c
    but i’m certainly not against updating and think we should align with vox as much as possible
  • c
    Like i say, we will be bumping the rubocop version for the modules soon… maybe we could use some of our tooling ecosystem as a stepping stone.
  • v
    could also be that it was an older version already
  • c
    true true
  • c
    Can you create an issue with your case for supporting a newer version of rubocop in the puppet-lint repo? I’ll talk to the team about it today and also do some testing.
  • c
    Your PR has been merged now too!
  • v
    technically I'm off until next week so I'll try to remember then
  • c
    sounds good - enjoy your break and thank you 🙂
  • b
    @Alex Fisher do you think it's helpfull for grafana_dashboard showing the diff of a dashboard?
    👀 1
  • b
    and I didn't find a param to disable the diff 😞
  • a
    oh sorry, I started looking and then something came up.
  • a
  • a
  • b
    yes
  • a
    I think I'm using the provisioning_dashboards parameter of the main class instead.
  • a
    However, have you tried wrapping your data for the 
    content
    property in 
    Sensitive()
  • a
    ?
  • a
    That might 'just work'.
  • b
    nice hack. will give that a try
  • a
    Hack? Isn’t that what it’s for?
  • a
    Hack? Isn’t that what it’s for?
  • b
    I dont want to redact sensitive data, I dont want a json diff with 500lines
  • b
    but sensitive should work, yes
  • s
    This message was deleted.
    b
    b
    • 3
    • 2
1...162163164...648Latest