# voxpupuli
- a
Alex Fisher
10/17/2022, 2:35 PMThanks. I'll merge it shortly assuming no one wants to play code golf on any of it. (I've got a feeling that some of the replacement code might be overly verbose, but can't come up with anything I prefer better!)⛳ 1 - m
Marty Ewings
10/17/2022, 2:57 PMwe gave up on this one too - s
smortex
10/19/2022, 4:38 PMHum, today is the deadline I set for having enough time after the event that can still be used for participants to take part of hacktoberfest: https://github.com/puppetlabs/community/discussions/27 Given the no-reply so far I guess this will not do it. Maybe next year? - b
binford2k
10/19/2022, 6:40 PMthanks for your efforts. Next year does seem like a better option to me - v
VoxBot
10/19/2022, 7:23 PMfor people interested in our webhook: I convinced Spritzgebaeck to implement some queueing: https://github.com/voxpupuli/webhook-go/pull/70❤️ 1 - v
VoxBot
10/19/2022, 7:23 PMdhollinger: maybe thats something you can take a look at - v
VoxBot
10/19/2022, 11:09 PMam I the only one that still hates the rename of master → main? - v
VoxBot
10/20/2022, 6:40 AMewoud: nope - c
Craig Gumbley
10/20/2022, 9:27 AMMorning! Ewoud, if you are about I’ve added some suggestions to your puppet-lint PR. Could you take a look? - c
Craig Gumbley
10/20/2022, 9:27 AMMorning! Ewoud, if you are about I’ve added some suggestions to your puppet-lint PR. Could you take a look? - m
Marty Ewings
10/20/2022, 10:18 AM@derdanne Hello! i put what i think is a sane PR into your NFS module to repoint some deps away from the old herculesteam project towards the new vox ones, https://github.com/derdanne/puppet-nfs/pull/155 could you kick off the unit tests? im only really set up for PDK stuff here! thank you - m
Marty Ewings
10/20/2022, 10:18 AM@derdanne Hello! i put what i think is a sane PR into your NFS module to repoint some deps away from the old herculesteam project towards the new vox ones, https://github.com/derdanne/puppet-nfs/pull/155 could you kick off the unit tests? im only really set up for PDK stuff here! thank you - m
Marty Ewings
10/20/2022, 10:19 AMI consume this module for a side project of mine, and having fewer deps, and the deps in the maintained VOX namespace validates my use case 🙂 - v
VoxBot
10/20/2022, 10:24 AMCraig: https://github.com/puppetlabs/puppetlabs_spec_helper/blob/a28e6e9c761d186399577dcb86e80cfae3c302b6/puppetlabs_spec_helper.gemspec#L27 is also causing problems in bundle install - why is the spec helper needed? - v
VoxBot
10/20/2022, 10:25 AMah, for litmus … - v
VoxBot
10/20/2022, 10:26 AMI wonder if we could extract fixture handling to a separate gem - I'd also depend on it in voxpupuli-acceptance - v
VoxBot
10/20/2022, 10:26 AMthat would be nice - c
Craig Gumbley
10/20/2022, 10:32 AMSounds like an interesting proposal. I’m wondering if bumping the spec_helper dependencies is better to do for now. Ideally I’d like to un-break puppe-lint first. - c
Craig Gumbley
10/20/2022, 10:34 AMI’m not 100% sure why puppet-lint is in spec_helpers - c
Craig Gumbley
10/20/2022, 10:35 AMAlso, fwiw I didn’t seem to get bundle issues.. not sure why. I’ll have to take a closer look - b
bastelfreak
10/20/2022, 10:35 AMbecause the spec helper configures puppet-lint - b
bastelfreak
10/20/2022, 10:35 AMwith excludes and disabled checks - c
Craig Gumbley
10/20/2022, 10:37 AMSo it does - cheers Tim - v
VoxBot
10/20/2022, 10:39 AMyes, I'll first fix up my PR, then we can release 3.0.1 and see if we can move the ecosystem to 3.0.0 - v
VoxBot
10/20/2022, 10:39 AMor 3.x rather - c
Craig Gumbley
10/20/2022, 10:39 AMThanks - v
VoxBot
10/20/2022, 10:40 AMalso, why was rubocp 1.6.x chosen? - v
VoxBot
10/20/2022, 10:40 AMit's not Ruby 3 compatible, which makes my life harder