# voxpupuli
- v
VoxBot
10/15/2022, 7:22 PMso it should be backwards compatible - v
VoxBot
10/15/2022, 7:22 PManarcat: that only has a sysvinit script, not a systemd service - v
VoxBot
10/15/2022, 7:22 PMewoud: I guess we could carry a patch to alias puppet.service in our package for this - v
VoxBot
10/15/2022, 7:22 PMlavamind: I think it'd help many users, even if it's not perfect - v
VoxBot
10/15/2022, 7:23 PMwe used to ship our own service file, but switched to the upstream one for 7.x - v
VoxBot
10/15/2022, 7:23 PMand I like that :) - v
VoxBot
10/15/2022, 7:23 PMbut it wouldnt make sense I think to try to upstream at service name alias - v
VoxBot
10/15/2022, 7:23 PMewoud: what does? - v
VoxBot
10/15/2022, 7:23 PMewoud: if you would be so kind as to file a bug on the BTS for this, so I don't forget - v
VoxBot
10/15/2022, 7:34 PMoh, I see you also packaged 7.20.0, good :) - v
VoxBot
10/15/2022, 9:24 PMlavamind: https://ekohl.nl/0001-Add-puppet.service-alias-to-puppet-agent.service.patch - would send a MR but looks like someone needs to approve my account on salsa before I can log in - v
VoxBot
10/15/2022, 9:24 PMI wonder if we should do it the other way around - v
VoxBot
10/15/2022, 9:25 PMbecause upstream service file is named puppet.service already, and we're changing it via d/rules - v
VoxBot
10/15/2022, 9:25 PMso maybe we should just add the alias to puppet-agent instead - v
VoxBot
10/15/2022, 10:04 PMI'd like that since it means I wouldn't have to modify anything - a
Alex Fisher
10/17/2022, 1:37 PMMorning all. Anyone got a moment to review/approve https://github.com/voxpupuli/puppet-grafana/pull/301 ? - a
Alex Fisher
10/17/2022, 1:37 PMMorning all. Anyone got a moment to review/approve https://github.com/voxpupuli/puppet-grafana/pull/301 ? - b
bastelfreak
10/17/2022, 1:39 PMwhy does github say all jobs were successful, but it has an annotation for not being idempotent - v
VoxBot
10/17/2022, 1:43 PMsince there's "pending" ther - v
VoxBot
10/17/2022, 1:46 PMah pending is below the annotation - a
Alex Fisher
10/17/2022, 1:52 PMI decided to leave the figuring out how best to deal with the
property for another time/PR.secure_json_data - b
bastelfreak
10/17/2022, 1:53 PMis that only on grafana 9 idempotent or on grafana 8 as well? - a
Alex Fisher
10/17/2022, 1:56 PMThat property has never worked idempotently. It's just in grafana 9, you have to use it, as the original non secure variants have been removed. - b
bastelfreak
10/17/2022, 1:57 PMso if people use the old method, it will stay idempotent for them? - b
bastelfreak
10/17/2022, 1:57 PMor to rephrase: is that a breaking change for grafana 8 users? - a
Alex Fisher
10/17/2022, 1:57 PMI don't really fancy doing any magic where we automatically munge our properties into secure_data. We should eventually just deprecate ours or perhaps print out some warnings if you try to use them with grafana 9+ - b
bastelfreak
10/17/2022, 1:58 PMI agree - a
Alex Fisher
10/17/2022, 1:58 PMNo, if you are still on grafana 8, the old properties still work. - b
bastelfreak
10/17/2022, 1:58 PMnice - a
Alex Fisher
10/17/2022, 1:59 PMand if you've upgraded to grafana 9, but never used basic auth with your datasource, then the type becomes idempotent again as I've removed the empty string property default.