yes. blacksmith creates the git tag, then bumps to -rc0 and then wants to push to master and then the tag

probably because you tag the merge commit, not the actual release commit: https://github.com/voxpupuli/puppet-unattended_upgrades/commit/f78c9379ceba6a04000457e13f3a13930428ff5e

I've the tag locally and can try to push it if you like. that should work

for now I removed the branch protection again

okay

I'm trying to update beaker's

CHANGELOG.md

using a github token (via CHANGELOG_GITHUB_TOKEN), but I'm still hitting a secondary github rate limit: https://gist.github.com/joshcooper/6d9679e6b96f81cec56b3beb04d90258 thoughts on how to work around that?

Hmm looks like https://github.com/github-changelog-generator/github-changelog-generator/issues/1010

Hmm looks like https://github.com/github-changelog-generator/github-changelog-generator/issues/1010

I manually updated the changelog for now: https://github.com/voxpupuli/beaker/pull/1743

I manually updated the changelog for now: https://github.com/voxpupuli/beaker/pull/1743

I'm thinking my PRs test failures at https://github.com/voxpupuli/puppet-mlocate/pulls are probably not my error....

can I get a review for https://github.com/voxpupuli/puppet-vault_lookup/pull/51

you got it

@bastelfreak I closed some issues that the Puppet runtime PR fixed. Can you regenerate the changelog?

Hi folks. Sorry to be a pest about this, but it's causing issues and I'm trying not to fork. Would it be possible to get a review on https://github.com/voxpupuli/puppet-systemd/pull/277? I don't think that the recent comment by Ewoud is a blocker, but I also don't have an approval 😕.

Hi folks. Sorry to be a pest about this, but it's causing issues and I'm trying not to fork. Would it be possible to get a review on https://github.com/voxpupuli/puppet-systemd/pull/277? I don't think that the recent comment by Ewoud is a blocker, but I also don't have an approval 😕.

lol, I was literally just commenting on that

I think our comments just crossed eachother

Haha 🤷

@ewoud Part of the issue is that I didn't want to dig the hooks for the resource into the rest of the catalog in case it created dependency cycles. Technically, that whole part isn't really needed but you risk having systems that were broken by the releases between this and 2.9.0 not getting fixed until a reboot.

The 100% correct thing to do would be to write a custom type that figures out what needs to be triggered and flips the services after reloading the daemon but that seems....excessive.

Running daemon-reload doesn't actually hurt anything if you run it twice, and that's pretty much the worst case scenario here.

Removed the lazy reload since it's technically optional to the fix

@Lumiere Did you happen to get a chance to test the systemd update?

nope

Ah well 😄

been a bit nuts at work

Fair enough. I keep finding more things that it fixes 😕

tvaughan: sorry for the slow review but technically I'm on leave until next week

ewoud: I was worried about that :-/