https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v
    binford2k, how straight forward is it to use rangefinder on non-puppetlabs repos? (like, uh, theforeman)
  • a
  • v
    I don't interact with modules directly - puppet_metrics_dashboard
  • v
  • v
    what are your thoughts about adding branch protection? modules that have modulesync 5.3.0 or higher have a check called Puppet / Test suite which can become required
  • v
    then we can enable auto merge on approval rather than waiting for the tests to pass and then getting back
  • v
    for the modulesync branch?
  • v
    I would be fine with that
  • v
    no, for the master branch
  • v
    I think that won't work because of our release process
  • v
    but to do so we need at least modulesync 5.3.0 because otherwise we need to list all individual tests
  • v
    hmm, not sure
  • v
    there is now "Require a pull request before merging" so I think you can just push into it without a PR if you don't check that
  • v
    want to try it? I now enabled the required check on unattended_upgrades so we can see when we do the next release?
  • v
    good idea
  • v
    do you depend on the wrong job name?
  • v
    CI / Puppet / Test suite (pull_request) Successful in 2s
  • v
    Test suite Expected — Waiting for status to be reported
  • v
    I think that was from the old test suite - should probably be rebased
  • v
    or maybe I picked the old name - I see you just rebased
  • v
    fixed :)
  • v
  • v
    blacksmith now fails because it cannot push to master
  • v
    bleh, that sucks
  • v
    I also think we should stop bumping the version to -rc0 and/or use a github action to run changelog/release tasks
  • v
    what you can do is in the PR have two commits: one to bump to x.y.z (the actual release) and one to bump to x.y.(z+1)-rc0 - then be sure to create the tag on the x.y.z commit
  • v
    when we've a branch protection people cannot do accidental releases -> bumping to -rc0 is pointless
  • v
    that would work around it, but does require proper tagging
  • v
  • v
    that's currently enforced via the release task
1...798081...648Latest