Puppet Community

<https://github.com/voxpupuli/modulesync_config/pull/787>

<@U1PC2RAH0> I guess that should be ok.  I've not seen that before.  Is it a Puppet 7 change?

looks like it. need to dig into the code. I think the catalog-differ shouldn't / doesn't need to care about the ordering in arrays

it probably should care for most cases.  Just maybe not the order of tags.

<@U1PC2RAH0> i see you pop up on <https://github.com/github-changelog-generator/github-changelog-generator/issues/971> alot… we have started hitting this on a couple of modules Have you come up with away to resolve it? we have been adding fake tags and then removing them again, which is a bit tedious

I think it may have something to do with rebased commits

sadly no. I can reproduce it on the beaker repository but not on any of our puppet module repositories

the beaker one has a very large history/many PRs/issues. I always guessed that that might be related, but wasn't able to prove it

I thought it may be number of PRS, but this is actually happening on one of our newest modules, however it has a lot of rebase commits

i think it may be something to do with the type of entryies in git history rather than number of PRs

<https://github.com/puppetlabs/puppet_operational_dashboards/runs/6835117801?check_suite_focus=true#step:6:113> something happened on pr 63

I saw that a few times on our repos as well. maybe those were all rebases

<@U5V9MMW9E> I can say that the tag list in the puppet code is different vs in the compiled catalog on puppet6 and 7. IMO it's fine to ignore it (at least for the tag parameter). I will try to come up with a patch

sure.  I can't see how the ordering of the `tags` metaparameter matters.  For other parameters though, it certainly can matter depending on the type.

so the ordering in the actual puppet class is identical to the ordering in the puppet7 catalog. in puppet6 it's wrong/different

maybe in puppet6 it was random/not deterministic and that was fixed in puppet7.

A thought - one thing that changed either late in the 6 series or in 7 was that classes brought in via resource like statements got evaluated immediately as opposed to being put on the lazy queue for resources. This was done because consistency was wanted between just including it with `include` (or the other functions leading to the same), or using the resource like `class { foo: ... }` syntax. I don't remember when this changed though. But this  does for sure affect the order resources gets included in the catalog.

and this is related to the order of tags on resources?

Yes, since the change I am talking about means that resources included in catalog from classes included via the resource like expression will now be included earlier than before the change, and since they are processed earlier their effect on tags will mean that unique tags from those appear earlier.

All I am saying is that this change _may_ be the origin of the observed difference.

can I get a quick review for <https://github.com/voxpupuli/puppet-catalog-diff/pull/85> and <https://github.com/voxpupuli/puppet-catalog-diff/pull/86> and (just some docs updates)

is hiera-eyaml still the preferred way to go to store hiera data encrypted?