https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • a
    I've done it for gitlab and jenkins with bitbucket server. I always ran it for all nodes.
  • a
    Which is kinda the point. Make sure your change isn't breaking some random node you hadn't even considered.
  • a
    How many nodes have you got?
  • b
    ~1000 across ~50 environments with an.... interesting merge strategy
  • a
    That should be fine then. I do about twice that.
  • b
    I think the biggest env just has 130 nodes. so diffing all doesn't take too long
  • a
    I use the option to filter to nodes that are currently in the PRs target branch.
  • a
    In your CI job, also make sure your PR/source branch is up to date with the target branch. (ie check that a fastforward only merge would work)
  • b
    ah yeah
  • b
    another question: README.md from catalog-diff says that puppet6 removed a lot of alias parameters, now I'm diffing puppet 6->puppet7 catalogs and see a lot of missing alias parameters. I'm wondering if there's a typo in README.md and they got actually removed in puppet 7, not 6. but I cannot find that in the puppet 7 changelog
  • a
    Also use a dedicated Puppetserver and have the job control when r10k is run. You don't want the environments to change part way through your job.
  • b
    yeah I've a complete PE environment just for catalog-diff
  • b
    without automatic code deploy
  • a
    I've not migrated to Puppet 7 yet. Still need to get some Solaris agents upgraded...
  • b
    sounds painful
  • a
    With PE, isn't there some native impact analysis functionality?
  • b
    I think only in CD4PE
  • a
    and that's something separate to buy/license?
  • b
    yes
  • a
    Might be interesting to compare the functionality. I always assumed they worked in a similar way.
  • a
    But... there are some limitations listed here https://puppet.com/docs/continuous-delivery/4.x/impact_analysis_limitations.html that don't make much sense
  • a
    "The impact of changes to a function cannot be analyzed." Why not??
  • b
    Alias metaparameter. Any resources using the alias metaparameter cannot be analyzed.
    Interesting
  • a
    and "The impact of changes made to Embedded Puppet (
    .epp
    ) or Embedded Ruby (
    .erb
    ) template files alone cannot be analyzed."
  • b
    as an engineer, I would have turned catalog-diff into a PE integration and offer support for it, and contribute patches back upstream. And not reinvent the wheel.
  • b
    But ¯\_(ツ)_/¯
  • b
    did you see the IRC query I send you some days ago?
  • b
    @Alex Fisher what do you think about sorting tags before we diff them? https://gist.github.com/bastelfreak/8ae96ce3564ad0b75621b8df7f3aec29
  • r
  • r
1...727374...648Latest