Puppet Community

And maybe we can deprecate accounting-related parameters in favour of system settings.. but it’ll break existing configurations

we can probably merge them and log a deprecation, and remove them in the future?

Sounds good, but then we’ll have no OS defaults for accounting options. Or we should manage sane defaults for system.conf, which is.. quite time consuming (we discussed it above yesterday iirc) :)

I think on all modern distributions systemd should support the same accounting options

can I get some feedback on <https://github.com/voxpupuli/beaker/pull/1906> ?

Hm. Trying to understand the implications. All acceptance test setups would require ruby 3.1 or newer then? So breaking change?

but they already run on ruby 3.3 in our pipeline

Ruby 3.1 got released in 2021, that's already quite ancient

well, I guess it will become a major version then..

so, back to rubocop rules..
&gt; spec/classes/init_spec.rb:600:15: C: [Correctable] Layout/DotPosition: Place the . on the previous line, together with the method call receiver. (<https://rubystyle.guide#consistent-multi-line-chains>)


&gt; spec/classes/init_spec.rb:602:28: C: [Correctable] Style/TrailingCommaInArguments: Avoid comma after the last parameter of a method call. (<https://rubystyle.guide#no-trailing-params-comma>)


I believe it was different before.. or maybe I’m biased by PDK rubocop rules

may I have review pls: <https://github.com/voxpupuli/puppet-systemd/pull/495>

not sure if .vscode/extensions.json removal should be part of this PR or better to make it separate PR

and if it's something to do everywhere, modulesync is the right place IMHO

Hello Community, is there a tool to diff Puppetfiles?

can I get a review for <https://github.com/voxpupuli/puppet-consul/pull/672> ?

<@U17J6MKV5> I'm a fan of `git diff --no-index Puppetfile_a Puppetfile_b`

Hm, doesn’t that get complicated, if structure and order is completely different?

and for <https://github.com/voxpupuli/puppet-wildfly/pull/345> and <https://github.com/voxpupuli/beaker/pull/1906> please

yes. In that case you should reorder the Puppetfile :D Or you can write something with r10k to get the puppetfile and diff the modules in a ruby script

in foreman-installer I use librarian_puppet as an API to parse it: <https://github.com/theforeman/foreman-installer/blob/develop/bin/module-versions>