https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • t

    tuxmea

    10/28/2024, 1:15 PM
    1. https://github.com/voxpupuli/puppet-wildfly/pull/341
  • t

    tuxmea

    10/28/2024, 1:15 PM
    2. https://github.com/voxpupuli/puppet-wildfly/pull/343
  • v

    VoxBot

    10/28/2024, 6:27 PM
    hrm, when I've BUNDLE_WITHOUT=development it would be nice if bundler actually ignores the development group
  • v

    VoxBot

    10/28/2024, 6:27 PM
    it poops itself when the gem group contains one gem that requires a newer ruby version than available :(
  • v

    VoxBot

    10/28/2024, 6:27 PM
    there's probably a workaround for this
  • v

    VoxBot

    10/28/2024, 6:31 PM
    it bundles without, but it still analyzes everything
  • v

    VoxBot

    10/28/2024, 6:31 PM
    have been bitten by this waaaay to many times
  • v

    VoxBot

    10/28/2024, 7:03 PM
    +1 to being bitten by it
  • v

    VoxBot

    10/28/2024, 7:09 PM
    Zhenech: and now you will present me a solution for this?
  • v

    VoxBot

    10/28/2024, 7:34 PM
    Can I get some feedback at https://github.com/voxpupuli/beaker/pull/1906 ?
  • j

    josh

    10/28/2024, 8:26 PM
    The fact that bundler still observed constraints for gems whose group is excluded/without is one of the reasons why we created separate Gemfiles for puppet vs acceptance/Gemfile.
  • j

    josh

    10/28/2024, 8:27 PM
    Sure seems like a bundler bug. It would be nice to not have to do that
  • b

    bastelfreak

    10/28/2024, 8:27 PM
    yeah 😞
  • b

    bastelfreak

    10/28/2024, 8:41 PM
    I pinged the bundler people
  • b

    bastelfreak

    10/28/2024, 8:50 PM
    Bundling without doesn’t re-resolve the Gemfile.lock because then we’d have a superposition of 2 Gemfile.locks that were incompatible with each other. I think there’s some tools like bundle-compose or bootboot that could help, but I don’t have a lot of experience with them.
  • y

    Yury Bushmelev

    10/29/2024, 2:49 AM
    RFC: what about adding
    c.filter_run_when_matching focus: true
    to our
    spec_helper.rb
    by default? This allows to focus on one example in RSpec test using
    focus: true
    meta or `fcontext`/`fit` (also rubocop exception may be good to add to the line).
  • y

    Yury Bushmelev

    10/29/2024, 2:49 AM
    I’m not sure about any cons of this though..
  • y

    Yury Bushmelev

    10/29/2024, 2:51 AM
    the only I can imagine - it’s easy to forget that you were working on focused examples and PR it in.. if rubocop disable comment is present, then no way to catch it except grepping explicitly.
  • y

    Yury Bushmelev

    10/29/2024, 3:22 AM
    Somehow I see some questionable rubocop settings 🤔 e.g. it tries to remove comma after the last item in a Hash in RSpec example. Also it tends to leave the
    .
    in the end of the previous line instead of beginning of next one. Is it something changed recently?
  • y

    Yury Bushmelev

    10/29/2024, 3:23 AM
    I mean things like that:
    Copy code
    it do
      <http://is_expected.to|is_expected.to> contain_foo('foo').
        with_ensure('present).
        with_value(true)
    end
  • y

    Yury Bushmelev

    10/29/2024, 3:24 AM
    usually it was always in the beginning of a line (
    .with_ensure(...)
    )
  • y

    Yury Bushmelev

    10/29/2024, 3:25 AM
    voxpupuli-test 9.2.0 is installed
  • b

    bastelfreak

    10/29/2024, 6:57 AM
    @Yury Bushmelev sounds interesting
  • y

    Yury Bushmelev

    10/29/2024, 7:02 AM
    Yeah.. I was quite surprised.. though now I think it might be something in my VSCode/Ruby LSP. Will check from CLI soon
  • y

    Yury Bushmelev

    10/29/2024, 7:03 AM
    Ah, do you mean focus? That’s quite useful. Huge time saver
  • b

    bastelfreak

    10/29/2024, 7:37 AM
    I meant both :D
    😄 1
  • b

    bastelfreak

    10/29/2024, 7:37 AM
    So we have a different rubocop config for gems vs puppet modules.
  • b

    bastelfreak

    10/29/2024, 7:37 AM
    Maybe they have different configs for the dot
  • y

    Yury Bushmelev

    10/29/2024, 8:41 AM
    I’ll recheck and update here. Meanwhile my systemd PR is ready for review. Cannot say I like the approach, but it should do the trick.
  • y

    Yury Bushmelev

    10/29/2024, 8:42 AM
    Also there is a lot of improvements pending after. The types I introduced should be used in other places (and more types should be introduced I believe)
1...607608609...648Latest