this if I remove the baseline_os filter as required in the ubuntu 24 PR

yeah, I think it makes sense to run the unit tests without the filter and then on a larger runner

mhm I can add a runner group to our org without a TOTP token, but to remove a runner group I need to authenticate again

review pls: https://github.com/voxpupuli/modulesync_config/pull/913

valantin: https://github.com/voxpupuli/puppet-zabbix/pull/967 that will make it fast

rwaffen: I review yours, you review mine?

question, is gentoo a OS supported by voxpupupli? I see it was removed from facterdb

we don't have something like officially supported operating systems

if something works and has tests, we can merge it

and on FacterDB we removed factsets from old Facter version, but there are still Gentoo factsets present

ok, so I need to understand why spec fails on gentoo-2-x86_64

ah ok I misunderstood this message "No facts were found in the FacterDB for Facter v4.2.8 on {:operatingsystem=>"Gentoo", :hardwaremodel=>"x86_64"}, using v3.14.5 instead"

that's fine. there's a complex logic to check which puppet version we use in unit tests, then we search for a matching facter version. then we check for a factset with the same facter minor version or an older factset

I need help, I don't understand why the tests fail on gentoo, it fail all the test

on which PR?

not pushed, I'm working to remove baselineos filter

fixed main problem i push it

\o/

can I get a review for https://github.com/voxpupuli/voxpupuli-rubocop/pull/64 ?

I've realise next relese of zabbix module was a major relese due to an already merged backwards-incompatible change

so probably next week I've massively require review to prepare next release

bastelfreak: this is the error in gentoo spec I'm tolking about https://github.com/voxpupuli/puppet-zabbix/actions/runs/9712083421/job/26806183342?pr=968

ah it assumes Gentoo has no systemd

ups I've probably found the problem, I've set manage_startup_script to true for Gentoo

is it, shame on me :D

not found before because not run the spec on gentoo...

that's exactly the reason why I don't like those filters

neat, Puppet now adopts voxpupuli-rubocop

bastelfreak: I'm forgot to rebase config update to https://github.com/voxpupuli/puppet-zabbix/pull/956 and mention it in the PR