:D

yeah

anyway, I see the value in being able to have defaults for the function on the Puppetserver, but they should probably be in their own file. Perhaps $confdir/ldapquery.yaml

yes

bastelfreak: do you want to make the CI task you just created a required check in librarian-puppet?

and enable autom-merge? :)

yes. but I wanted to ask you if I should make that now or after 106 is merged

because you will need to rebase all prs after I enable it

probably wait until 106 is merged, CI shouldn't take too long anymore

I'll grab some lunch in the mean time

guten

warning: /home/runner/work/librarian-puppet/librarian-puppet/vendor/bundle/ruby/2.7.0/gems/puppet_forge-3.2.0/lib/puppet_forge/v3/module.rb2 warning: loading in progress, circular require considered harmful - /home/runner/work/librarian-puppet/librarian-puppet/vendor/bundle/ruby/2.7.0/gems/puppet_forge-3.2.0/lib/puppet_forge/v3/user.rb

meh

I wonder why Puppet 6 now fails in CI: expected "librarian-puppet install" to have finished in time (RSpec:Expectations:ExpectationNotMetError)

bastelfreak: perhaps that's fixed when we update to puppet_forge 4, so for now I'll ignore it

yeah just merge it

but lunch :)

@Alex Fisher would it be possible to have https://github.com/voxpupuli/puppet-ldapquery/pull/40 merged before the new release so it is included?

I want to get that functionality in soon, but I think I should make that part of reworking where the ldap config is sourced.

that one needs to be rebased

@cruelsmith I'm going to work on it this afternoon.

In particular I need multi-server support.

multi-server support via the puppet config or via parameter? Or for each query like an array of hosts for the query?

I still want to be able to load default ldap config from a file with the possibility of overriding it per function call.

Just probably not from

puppet.conf

a yaml file would allow some parameters to be hashes or arrays and more closely match the net-ldap ruby library.

I also worry that those settings will be removed from Puppet and certainly that no others will ever be added. At the moment, there are some settings that can only be set via the hash passed to the function. It's just too confusing and inconsistent.

ok thanks.

(Not a reflection on your change BTW, it was already like that!) 🙂