https://github.com/voxpupuli/puppet-openssl/blob/master/lib/puppet/functions/cert_aia_caissuers.rb#L46 works for puppet6 but not puppet7; and I have no idea why :P

but is it really failing there, or on the "The code loaded from /home/runner/work/puppet-openssl/puppet-openssl/vendor/bundle/ruby/2.7.0/gems/puppet-7.24.0/lib/puppet/datatypes/error.rb does not seem to be a Puppet 5x API data type - no create_type call." thing?

Excellent question, just stumbled in there too. I will try to fix the later and see if the rescue stuff is still a problem or resolved too. I always forget that just because its marked as error in the CLI; it does not mean it necessarily is

pretty sure it's not the File.read, as the tests that are failing are https://github.com/voxpupuli/puppet-openssl/blob/master/spec/functions/cert_aia_caissuers_spec.rb#L26

not the ones above that pass an invalid file

zilchms, seems the allow(File).to receive(:read) is not working correctly

ok, the problem is that with the allow(File) we're breaking all file reads inside puppet -.-

yea xd the testsuite of the whole module seems a bit off

zilchms, https://github.com/voxpupuli/puppet-openssl/pull/162#issuecomment-1545842631

that makes tests pass here

i am currently looking into it if i can get it fixed up

oh thanks, didnt notice :D

did I mention I hate mocks?

I hate that mocks in rspec-puppet are entirely undocumented

^ this

https://github.com/voxpupuli/puppet-openssl/pull/162 can i get a review?

doesn't look crazy to me :)

but my puppet functions knowledge is very limited

thanks for merging bastelfreak :) now the not-so-nice part: puppetforge releases; i think we need one release with the current master (where both 6 and 7 are supported) and then a major release where puppet6 support is droped

puppet 6 is already dropped on master

"requirements": [

{

"name": "puppet",

"version_requirement": ">= 6.1.0 < 8.0.0"

}

now i might see this wrong; but i dont think so?

oh my pr to drop puppet 6 wasnt merged yet

but I dont see why we should do a release just to support puppet 6

we already have to do a major release, so we could also drop puppet 6 IMO