And guess who signed off on the PR?

both you and me :P

bastelfreak: unrelated, but if it's a reasonable hour there and you get a sec, can you see if https://github.com/voxpupuli/puppet-rabbitmq/pull/932 is what you were asking for with the os_facts? also added support for FreeBSD

I don't think I'm going to try to pull the defaults back out from data in any of the PRs I'm working on now. Maybe after we get modulesync working and the existing breaking changes released

it is always a reasonable hour to review puppet code

bastelfreak: hah. thank you... appreciated.

your welcome!

I took a stab at going one step further towards fixing the arch acceptance tests, and can't even get it to run locally :/

I feel like either someone who understands both Arch and rabbitmq needs to take a stab at it, or we need to drop official support, tho if you have any thoughts on making acceptance tests work, I can give it one more shot. right now it just gets in a loop where it can't ssh in to bootstrap puppet

also, do we want os_facts[:osfamily] or os_facts['os']['family'] in specs?

osfamily is the legacy fact, we should not use it

for now you can drop arch linux from the metadata.json

bastelfreak: thanks - I think that will be smart until someone has time to fix it. And, if modulesync is needed before the next release, would be really helpful if someone who's got more of a clue with this stuff takes a look

I can make a PR to standardize :osfamily

bastelfreak: you want that one flagged as breaking too? (might as well since we've got 2-3 other ones to release)

can I get a review for https://github.com/voxpupuli/modulesync_config/pull/831

Hey everyone, I just want to drop this blog post here to make sure you are all aware of the major changes in stdlib with function removal: https://puppetlabs.github.io/content-and-tooling-team/blog/posts/2023-05-12-deprecation-of-stdlib-functions/

just curious: does anyone know if File.read changed behaviour between puppet6 and puppet7?

been going through changelogs of puppet and ruby to gain some info, but so far no luck

I'd say "shouldn't", but you know, never say never

what are you seeing?

have a look at https://github.com/voxpupuli/puppet-openssl/actions/runs/4958660326/jobs/8871820821

In puppet6 the tests are fine; in puppet7 the same tests fail with an rb_sysopen error (which to be fair is not unexpected). Its more that I am wondering how it has been working in puppet6 xd

or to be more specific: for puppet7 the StandardError for rb_sysopen isnt rescued properly it seems; as the implementation expects an error and should propagate it as a warning, but still return a value "nil"

"quickly" installing a 2.4 ruby to check smth :D

irb(main)0010> File.read('/lol')

Errno:ENOENT No such file or directory @ rb_sysopen - /lol

no, that too correctly fails

yea, failing is the intended behaviour and didnt change, but rescueing the error seems to work different?