https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v
    https://github.com/voxpupuli/hiera-eyaml/pull/328 looks fine, except that we currently do not run the coverage report. we would need to set the COVERAGE env var to yes, for only one CI job and I'm not sure how to do that in the github action matrix magic
  • v
  • v
    add a step where you set the var with if: ${{ matrix.ruby }} == "3.1"
  • v
  • v
  • v
  • v
    e-woud: What's with the hyphen in your nic?
  • a
    "https://github.com/puppetlabs/puppetlabs-stdlib/pull/1196 should not have been merged" Discuss! 😉
  • a
    "https://github.com/puppetlabs/puppetlabs-stdlib/pull/1196 should not have been merged" Discuss! 😉
  • v
    A user in #fedora:fedoraproject.org kindly shared https://kparal.wordpress.com/2021/06/01/connecting-to-libera-chat-through-matrix/ with me - it walks you through every step of registering and logging into an IRC nick from Matrix and was super helpful. Sharing here in hopes it helps others
  • v
    afisher: IMO as a breaking change that's valid. puppet-lint will yell at your package example because ensure should be installed or purged
  • v
    of course it would be nice if Puppet would detect that ensure and installed are equal here
  • a
    and how are you supposed to deal with it being a breaking change? get puppetlabs to update all their modules to use 
    installed
    instead of 
    present
    ??
  • v
    in how many places do you use ensure_packages?
  • v
    I had 0 conflicts with this change in my environment
  • v
    afisher: it's my alt nick in irssi - I think keepnick.pl may not be doing its thing
  • a
    ensure_packages
    was always suppose to be a convenience function that let you do things like 
    include apache
    but in some other profile or module evaluated later do 
    ensure_packages('httpd')
    or whatever. Now you can't in the cases you could before.
  • a
    and there's no fix. If you fix up various modules so to become compatible with stdlib 8's version of the function, they become incompatible with stdlib < 8.
  • v
    yes. you need to upgrade the other modules
  • a
    all at the same time
  • v
    how many of your modules are effected?
  • v
    that can't be that many?
  • v
    or do you always use ensure_package?
  • a
    Obviously I can go through my/colleagues code and come up with fixes by removing the use of the function, but IMO it's been broken for no good reason and in a way that makes it less useful than before.
  • v
    well, I already complained about it back then
  • v
    we have fixed a few instances in our Foreman modules, but that was mostly just fixing the test expectations
  • a
    Go through the list of puppetlabs supported modules and see which ones install packages with 
    ensure => present
    vs 
    ensure => installed
    (or no 
    ensure
    parameter)
  • a
    My randomly clicked on links from the forge produced this. https://github.com/puppetlabs/puppetlabs-stdlib/pull/1196#issuecomment-1132872127
  • a
    My randomly clicked on links from the forge produced this. https://github.com/puppetlabs/puppetlabs-stdlib/pull/1196#issuecomment-1132872127
  • v
    TIL: you can update your .git/remotes/refs/origin/HEAD using git remote set-head origin -a
1...424344...648Latest