https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v

    VoxBot

    05/20/2022, 9:43 AM
    https://github.com/voxpupuli/hiera-eyaml/pull/328 looks fine, except that we currently do not run the coverage report. we would need to set the COVERAGE env var to yes, for only one CI job and I'm not sure how to do that in the github action matrix magic
  • v

    VoxBot

    05/20/2022, 9:46 AM
    bastelfreak: https://docs.github.com/en/actions/learn-github-actions/environment-variables#passing-values-between-steps-and-jobs-in-a-workflow perhaps that's easier?
  • v

    VoxBot

    05/20/2022, 9:47 AM
    add a step where you set the var with if: ${{ matrix.ruby }} == "3.1"
  • v

    VoxBot

    05/20/2022, 9:47 AM
    so really https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-environment-variable
  • v

    VoxBot

    05/20/2022, 10:02 AM
    https://github.com/voxpupuli/hiera-eyaml/runs/6522710245?check_suite_focus=true it's working
  • v

    VoxBot

    05/20/2022, 10:31 AM
    can I get a review for https://github.com/voxpupuli/puppet-network/pull/285
  • v

    VoxBot

    05/20/2022, 12:39 PM
    e-woud: What's with the hyphen in your nic?
  • a

    Alex Fisher

    05/20/2022, 12:48 PM
    "https://github.com/puppetlabs/puppetlabs-stdlib/pull/1196 should not have been merged" Discuss! 😉
  • a

    Alex Fisher

    05/20/2022, 12:48 PM
    "https://github.com/puppetlabs/puppetlabs-stdlib/pull/1196 should not have been merged" Discuss! 😉
  • v

    VoxBot

    05/20/2022, 12:53 PM
    A user in #fedora:fedoraproject.org kindly shared https://kparal.wordpress.com/2021/06/01/connecting-to-libera-chat-through-matrix/ with me - it walks you through every step of registering and logging into an IRC nick from Matrix and was super helpful. Sharing here in hopes it helps others
  • v

    VoxBot

    05/20/2022, 12:54 PM
    afisher: IMO as a breaking change that's valid. puppet-lint will yell at your package example because ensure should be installed or purged
  • v

    VoxBot

    05/20/2022, 12:54 PM
    of course it would be nice if Puppet would detect that ensure and installed are equal here
  • a

    Alex Fisher

    05/20/2022, 12:55 PM
    and how are you supposed to deal with it being a breaking change? get puppetlabs to update all their modules to use
    installed
    instead of
    present
    ??
  • v

    VoxBot

    05/20/2022, 12:58 PM
    in how many places do you use ensure_packages?
  • v

    VoxBot

    05/20/2022, 12:58 PM
    I had 0 conflicts with this change in my environment
  • v

    VoxBot

    05/20/2022, 12:58 PM
    afisher: it's my alt nick in irssi - I think keepnick.pl may not be doing its thing
  • a

    Alex Fisher

    05/20/2022, 1:03 PM
    ensure_packages
    was always suppose to be a convenience function that let you do things like
    include apache
    but in some other profile or module evaluated later do
    ensure_packages('httpd')
    or whatever. Now you can't in the cases you could before.
  • a

    Alex Fisher

    05/20/2022, 1:04 PM
    and there's no fix. If you fix up various modules so to become compatible with stdlib 8's version of the function, they become incompatible with stdlib < 8.
  • v

    VoxBot

    05/20/2022, 1:05 PM
    yes. you need to upgrade the other modules
  • a

    Alex Fisher

    05/20/2022, 1:05 PM
    all at the same time
  • v

    VoxBot

    05/20/2022, 1:06 PM
    how many of your modules are effected?
  • v

    VoxBot

    05/20/2022, 1:06 PM
    that can't be that many?
  • v

    VoxBot

    05/20/2022, 1:06 PM
    or do you always use ensure_package?
  • a

    Alex Fisher

    05/20/2022, 1:08 PM
    Obviously I can go through my/colleagues code and come up with fixes by removing the use of the function, but IMO it's been broken for no good reason and in a way that makes it less useful than before.
  • v

    VoxBot

    05/20/2022, 1:09 PM
    well, I already complained about it back then
  • v

    VoxBot

    05/20/2022, 1:09 PM
    we have fixed a few instances in our Foreman modules, but that was mostly just fixing the test expectations
  • a

    Alex Fisher

    05/20/2022, 1:09 PM
    Go through the list of puppetlabs supported modules and see which ones install packages with
    ensure => present
    vs
    ensure => installed
    (or no
    ensure
    parameter)
  • a

    Alex Fisher

    05/20/2022, 1:09 PM
    My randomly clicked on links from the forge produced this. https://github.com/puppetlabs/puppetlabs-stdlib/pull/1196#issuecomment-1132872127
  • a

    Alex Fisher

    05/20/2022, 1:09 PM
    My randomly clicked on links from the forge produced this. https://github.com/puppetlabs/puppetlabs-stdlib/pull/1196#issuecomment-1132872127
  • v

    VoxBot

    05/20/2022, 1:09 PM
    TIL: you can update your .git/remotes/refs/origin/HEAD using git remote set-head origin -a
1...424344...648Latest