@josh puppet 8? 🙂

you could add that in 7 since technically it's opt-in

Is that a typo? Or were you actually suggesting adding

Puppet::Property::Bool

as a working replacement to

Puppet::Property::Boolean

?

https://github.com/puppetlabs/puppet/blob/main/lib/puppet/property/boolean.rb is 'used' in plenty of places even though it doesn't work.

https://github.com/puppetlabs/puppet/blob/main/lib/puppet/property/boolean.rb is 'used' in plenty of places even though it doesn't work.

mangling bools to symbols alone isn't enough as you end up with

Notice: /Stage[main]/Profile::Core::Puppet_master/Foreman_global_parameter[this-is-a-test]/value: value changed false to 'false' (corrective)

ah not a typo, we'd need to use something other than

Puppet::Property::Boolean

::Poolean

::Foolean

Your provider probably also needs to produce symbols when fetching the current state.

@josh Sounds good then. That should definitely be non breaking. (tempting fate)

@tvaughan's hack seems to work.

(@should - [true,:true]).empty?

is blowing my mind

@tvaughan's hack seems to work.

(@should - [true,:true]).empty?

is blowing my mind

Also https://tickets.puppetlabs.com/browse/PUP-8442 is the same issue, but for parameters

We tried fixing it, but had to revert because it broke the vcsrepo module (it starting defaulting to

force => true

)

Hmm. Why doesn't this work?

require 'puppet/property/boolean'

module PuppetX
  module Foreman
    module Property
      class Foolean < Puppet::Property::Boolean
        def should
          return nil unless defined?(@should)
          (@should - [true,:true]).empty?
        end

        def insync?(is)
          is == should
        end
      end
    end
  end
end

and

newproperty(:value, boolean: true, parent: PuppetX::Foreman::Property::Foolean) do
    desc 'Parameter value'
  end

must be something to do with #genclass/#genthing

ARGH, it doesn't transition true -> false when migrated back to the newproperty block arg either. I swore I tested that as working.

Is there any desire from peeps here for a module to manage Falco? Asking because I have been working on reviving one that seem to have been abandoned and am trying to figure out where to have it live

if you want to put some love into the module you could do that in our namespace

and utilize our modulesync/ci setup

Thanks bastelfreak - I just wasn't sure how niche this was

I think as long as the person wanting it migrated is able and willing to see the process through to a release, it doesn't matter too much if there isn't a huge amount of interest.

@Alex Fisher That person is me. The old code was in a subdirectory of a larger repo and a version from 3 years ago is on the Forge... I exported the code to a new repo and have been working on it there

That part all started when I was trying to deploy a patched version of the code via git and couldn't due to it being embedded in the other repo. I have a couple of PRs open on the original and will see if there is any traction there. If so, I will likely ask them about marking the abandoned one as superseded by the new one I am fixing up.

@genebean this is a puppet mode to install the kernel driver?

This message was deleted.

can I get a final review for https://github.com/voxpupuli/puppet-augeasproviders_apache/pull/11 ? I think this is ready now and most of the changes can be applied to all the augeasproviders modules

And can I get some eyes on https://github.com/voxpupuli/hiera-eyaml/pull/329 ? CI fails when we switch from Puppet 6 to 7, that's required to test hiera-eyaml on newer ruby

e-woud: are you around? :)