https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v

    VoxBot

    04/14/2023, 4:05 PM
    I'd suspect https://github.com/hercules-team/augeas/commit/eb04250a05671b2d001444b72b8778328d209d75 given it does make changes to file handling
  • v

    VoxBot

    04/14/2023, 4:05 PM
    and this is rather short: git log release-1.12.0..release-1.13.0 src/
  • y

    Yury Bushmelev

    04/14/2023, 4:07 PM
    let me try to build this one and prev commit to compare
  • y

    Yury Bushmelev

    04/14/2023, 4:11 PM
    ewoud: you’re right
  • y

    Yury Bushmelev

    04/14/2023, 4:11 PM
    this is THE commit!
  • y

    Yury Bushmelev

    04/14/2023, 4:12 PM
    it works with previous one and broken with this one
  • v

    vchepkov

    04/14/2023, 4:13 PM
    https://github.com/hercules-team/augeas/pull/691
  • v

    vchepkov

    04/14/2023, 4:13 PM
    https://github.com/hercules-team/augeas/pull/691
  • s

    Slackbot

    04/14/2023, 4:14 PM
    This message was deleted.
    y
    d
    • 3
    • 3
  • d

    David Sandilands

    04/14/2023, 4:14 PM
    With the content and tooling teams focus heading towards PDK 3 we would like to archive and put in the toy box PCT https://github.com/puppetlabs/pct and PRM https://github.com/puppetlabs/prm and elements of their work will be put into PDK 3. We didn't formally release a 1.x version of either but I wanted to check is there any issue with this/disruption we could cause?
  • y

    Yury Bushmelev

    04/14/2023, 4:18 PM
    well.. it seems it’s time to raise an issue wrt what we found with libaugeas..
  • y

    Yury Bushmelev

    04/14/2023, 4:19 PM
    it’d be nice to have small reproducer which doesn’t require the puppet though..
  • y

    Yury Bushmelev

    04/14/2023, 4:20 PM
    maybe I can craft something..
  • y

    Yury Bushmelev

    04/14/2023, 4:25 PM
    well.. I just copied an example and it works fine with ruby 😕
  • v

    VoxBot

    04/14/2023, 4:28 PM
    just plain ruby-augeas instead of Puppet?
  • y

    Yury Bushmelev

    04/14/2023, 4:31 PM
    yes.. you know what.. I see no
    aug.save
    in the provider code
  • v

    VoxBot

    04/14/2023, 4:32 PM
    https://github.com/voxpupuli/puppet-augeasproviders_core/blob/d3fc5676040291aaa3023e7102af4ca297691621/lib/puppet/provider/augeasprovider/default.rb#L919-L929
  • y

    Yury Bushmelev

    04/14/2023, 4:33 PM
    ah.. I was looking into the sysctl one.. it’s inherited I guess
  • y

    Yury Bushmelev

    04/14/2023, 4:40 PM
    Copy code
    jay@ubuntu2004:~$ cat test_aug.rb 
    #!/opt/puppetlabs/puppet/bin/ruby
    
    require 'augeas'
    
    Augeas::open do |aug|
    jay@ubuntu2004:~$ sudo ./test_aug.rb 
    jay@ubuntu2004:~$ cat /etc/sysctl.d/rubytest.conf 
    fs.nr_open = 100001
    fs.inotify.max_user_watches = 8193
  • y

    Yury Bushmelev

    04/14/2023, 4:40 PM
    oops
  • y

    Yury Bushmelev

    04/14/2023, 4:40 PM
    Copy code
    jay@ubuntu2004:~$ cat test_aug.rb 
    #!/opt/puppetlabs/puppet/bin/ruby
    
    require 'augeas'
    
    Augeas::open do |aug|
      aug.set("/files/etc/sysctl.d/rubytest.conf/fs.nr_open", "100001")
      aug.set("/files/etc/sysctl.d/rubytest.conf/fs.inotify.max_user_watches", "8193")
      unless aug.save
        raise IOError, "Failed to save changes"
      end
    end
  • y

    Yury Bushmelev

    04/14/2023, 4:40 PM
    so this example is fine
  • y

    Yury Bushmelev

    04/14/2023, 4:41 PM
    it should use the same ruby and libaugeas version as Puppet
  • b

    bastelfreak

    04/14/2023, 4:41 PM
    @Alex Fisher the modulesync PR passed \o/ is that now ready for review?
  • v

    vchepkov

    04/14/2023, 4:43 PM
    @Yury Bushmelev. running your code:
    Copy code
    $ ./test_aug.rb 
    Traceback (most recent call last):
    	2: from ./test_aug.rb:5:in `<main>'
    	1: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/augeas.rb:51:in `open'
    ./test_aug.rb:9:in `block in <main>': Failed to save changes (IOError)
  • y

    Yury Bushmelev

    04/14/2023, 4:44 PM
    sudo is important.. you cannot write to the /etc/sysctl.d
  • v

    vchepkov

    04/14/2023, 4:44 PM
    oh, damn, let me change path to /tmp
  • y

    Yury Bushmelev

    04/14/2023, 4:44 PM
    and if path is changed then lens should be adjusted
    ✔️ 1
  • y

    Yury Bushmelev

    04/14/2023, 4:44 PM
    (I guess)
  • y

    Yury Bushmelev

    04/14/2023, 5:19 PM
    well.. I had no luck with reproducing the issue in ruby.. giving up
1...417418419...647Latest