https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • y

    Yury Bushmelev

    04/14/2023, 11:38 AM
    and for debian 11 aarch64 too
  • r

    Robert Waffen

    04/14/2023, 11:50 AM
    mom, thats not all, if you wanna see diff, add this your nodeset file
    Copy code
    default_apply_opts:
          show_diff:
  • r

    Robert Waffen

    04/14/2023, 11:51 AM
    and yes, it has to be an empty hash
  • v

    VoxBot

    04/14/2023, 11:52 AM
    isn't the value then nil? I think it translates to {"default_apply_opts" => {"show_diff" => nil}}
  • v

    VoxBot

    04/14/2023, 11:53 AM
    but if you want better support for it: https://github.com/voxpupuli/beaker-puppet/blob/166f2a829af05db5841b6258185f102882978682/lib/beaker-puppet/helpers/puppet_helpers.rb#L456 could be made aware of show_diff and an env var
  • v

    VoxBot

    04/14/2023, 11:54 AM
    I'm happy to review patches!
  • r

    Robert Waffen

    04/14/2023, 11:56 AM
    no if the value ist nil it is treated as a optionless parameter. so it will result in only
    --show_diff
    . if you set anything it will be transformed into
    --show_diff=anything
  • y

    Yury Bushmelev

    04/14/2023, 11:56 AM
    Copy code
    root@ubuntu2004:/etc/sysctl.d# rm 50-test.conf 
    root@ubuntu2004:/etc/sysctl.d# cat test.aug 
    set /files/etc/sysctl.d/50-test.conf/kernel.sysrq 438
    set /files/etc/sysctl.d/50-test.conf/net.ipv4.conf.all.log_martians 1
    save
    root@ubuntu2004:/etc/sysctl.d# augtool -f test.aug 
    Saved 1 file(s)
    root@ubuntu2004:/etc/sysctl.d# ls -la 50-test.conf 
    -rw-r--r-- 1 root root 54 Apr 14 11:56 50-test.conf
  • y

    Yury Bushmelev

    04/14/2023, 11:57 AM
    so it works fine via the augtool 🤔
  • y

    Yury Bushmelev

    04/14/2023, 11:58 AM
    can use
    ~
    for
    nil
    value in YAML IIRC
  • r

    Robert Waffen

    04/14/2023, 11:59 AM
    try it. I tried it my way and it worked for me so i didn't test anything else
  • r

    Robert Waffen

    04/14/2023, 11:59 AM
    try it. I tried it my way and it worked for me so i didn't test anything else
  • y

    Yury Bushmelev

    04/14/2023, 11:59 AM
    forgot to cat the file above:
    Copy code
    root@ubuntu2004:/etc/sysctl.d# cat 50-test.conf 
    kernel.sysrq = 438
    net.ipv4.conf.all.log_martians = 1
  • y

    Yury Bushmelev

    04/14/2023, 11:59 AM
    so both values are there
  • r

    Robert Waffen

    04/14/2023, 11:59 AM
    yaml spec ist a bit fuzzy there no key and ~are resulting both in nil
  • y

    Yury Bushmelev

    04/14/2023, 12:00 PM
    yep, you’re right but I’m always confused with such “hanging” hash keys 🙂
  • r

    Robert Waffen

    04/14/2023, 12:00 PM
    jea, you are right. its confusing to read
  • y

    Yury Bushmelev

    04/14/2023, 12:00 PM
    it looks like something is missing or next line is part of the hash
  • y

    Yury Bushmelev

    04/14/2023, 12:00 PM
    but nvm.. style things
  • y

    Yury Bushmelev

    04/14/2023, 12:09 PM
    lib version was bumped in augeas v1.13.0 as I see..
  • y

    Yury Bushmelev

    04/14/2023, 12:12 PM
    theoretically it should be possible to use git bisect to find the breaking commit..
  • y

    Yury Bushmelev

    04/14/2023, 12:31 PM
    well.. I guess I’ll try to do this ^
    clapping 1
  • y

    Yury Bushmelev

    04/14/2023, 1:15 PM
    Just realised the problem is reproduced with Ubuntu 20.04's libaugeas.so.0.24.2
  • v

    VoxBot

    04/14/2023, 1:27 PM
    could be in the ruby-augeas bindings as well
  • y

    Yury Bushmelev

    04/14/2023, 3:21 PM
    actually I was wrong, puppet uses another library path.. will retry again
  • y

    Yury Bushmelev

    04/14/2023, 4:00 PM
    so it works with augeas 1.12.0 but doesn’t with 1.13.0
  • v

    VoxBot

    04/14/2023, 4:01 PM
    that at least narrows it down
  • y

    Yury Bushmelev

    04/14/2023, 4:01 PM
    now it’s time to narrow it down even more 🙂
  • v

    VoxBot

    04/14/2023, 4:02 PM
    https://github.com/hercules-team/augeas/blob/41b2a33ff02687fa53d69a012a1d47141b196a86/NEWS#L41-L99
  • v

    VoxBot

    04/14/2023, 4:02 PM
    anyone able to provide a review on https://github.com/voxpupuli/puppet-dnsquery/pull/129 please :)
1...416417418...647Latest