Puppet Community

I’d expect maybe it’s something between ruby and puppet providers.. so not sure if there is any point to raise the issue in the augeas repo

I copied some parts of provider’s code into a test ruby file but linearly it works nice (without yields and post_resource_evals

I can share if anyone would like to play with it more

you could try to see if disabling the post_resource_eval feature and using explicit flushes works

and perhaps <https://github.com/voxpupuli/puppet-augeasproviders_sysctl/blob/d2822732c6cfc07fdf28460390562405110273c4/lib/puppet/provider/sysctl/augeas.rb#L283-L286> is a problem?

can I get a review for <https://github.com/voxpupuli/modulesync/pull/267>

smortex: another one: <https://github.com/voxpupuli/modulesync_config/pull/821>

I'll need to read the docs first. If nobody shows up in the meantime I can give it a try.

<https://github.com/voxpupuli/modulesync_config#syncing-all-modules|https://github.com/voxpupuli/modulesync_config#syncing-all-modules>

if you want to create the PRs automatically you also need the GITHUB_BASE_URL environment variable

I think GITHUB_BASE_URL=<https://api.github.co><https://api.github.com|m>

I'm getting an error on one of the repositories:
```Not managing 'spec/spec_helper_acceptance.rb' in 'puppet-puppet_certificate'
puppet-puppet_certificate: git '--git-dir=/Users/massimiliano.adamo/repos/modulesync_config/modules/voxpupuli/puppet-puppet_certificate/.git' '--work-tree=/Users/massimiliano.adamo/repos/modulesync_config/modules/voxpupuli/puppet-puppet_certificate' '-c' 'core.quotePath=true' '-c' 'color.ui=false' 'push' 'origin' 'modulesync'  2&gt;&amp;1
status: pid 14822 exit 128
output: "ERROR: Permission to voxpupuli/puppet-puppet_certificate.git denied to maxadamo.\nfatal: Could not read from remote repository.\n\nPlease make sure you have the correct access rights\nand the repository exists.\n"```


There's a small bug. It requires "DEBUG" to be set in advance from the shell.
```$ bundle exec bin/get_all_the_diffs
To use retry middleware with Faraday v2.0+, install `faraday-retry` gem
bundler: failed to load command: bin/get_all_the_diffs (bin/get_all_the_diffs)
bin/get_all_the_diffs:25:in `[]=': no implicit conversion of false into String (TypeError)
	from bin/get_all_the_diffs:25:in `&lt;top (required)&gt;'
	from /opt/homebrew/Cellar/ruby@3.0/3.0.6/lib/ruby/3.0.0/bundler/cli/exec.rb:58:in `load'
....```


meantime, I got two questions (and a coffee to drink :coffee: ) :stuck_out_tongue:
*first question*:
I see lot of messages like these:
```Checking modules/voxpupuli/puppet-amanda/metadata.json
  puppetlabs/concat (&gt;= 4.1.0 &lt; 7.0.0) doesn't match 8.0.0
Checking modules/voxpupuli/puppet-appd_db_agent/metadata.json
  puppetlabs/java (&gt;= 1.5.0 &lt; 5.0.0) doesn't match 9.0.1
  puppet/archive (&gt;= 1.1.2 &lt; 6.0.0) doesn't match 6.1.2
Checking modules/voxpupuli/puppet-archive/metadata.json```
or like these:
```Checking modules/voxpupuli/puppet-augeasproviders/metadata.json
  herculesteam/augeasproviders_base was superseded by puppet-augeasproviders_base
  herculesteam/augeasproviders_grub was superseded by puppet-augeasproviders_grub
  herculesteam/augeasproviders_pam was superseded by puppet-augeasproviders_pam```
They are too many. Is it something we need to take care now?
*Second question*:
I checked a few modules, and I see the changes in the branch `modulesync` but the instructions in the README stop here.
Is that all I had to do?

I havent used the get_all_diffs script in ages

you invoked msync without the --pr option. the branches are pushed, but the PRs are missing. cna you create them? you can jse the `hub` cli for that

<https://github.com/voxpupuli/modulesync_config/blob/master/bin/create-pull-requests|https://github.com/voxpupuli/modulesync_config/blob/master/bin/create-pull-requests> that should work

then wen can review the PRs. in some we probably need to update deps in the metadata.json, in some we need to uodate the reference.md

```You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later.```
I will try again later...

I was under the impression that the "bundle" command does not create the PR. I copy and paste and, I'm almost sure that I used the option "--pr", then I started using hub, but I exceeded the rate limits

it's per minute rate. I've added 15 seconds sleep after each pull request and now it's working

lot of problems. I ran one manually, I ran another after 10 seconds and I got error.
``` massimiliano.adamo  GA0428-MADAMO ~ repos … modules ~ voxpupuli ~ puppet-hashi_stack ~ modulesync $ hub pull-request -p -m "modulesync ${version}" -l "modulesync"
branch 'modulesync' set up to track 'origin/modulesync'.
Everything up-to-date
Error creating pull request: Unprocessable Entity (HTTP 422)
A pull request already exists for voxpupuli:modulesync.
 massimiliano.adamo  GA0428-MADAMO ~ repos … modules ~ voxpupuli ~ puppet-hashi_stack ~ modulesync $ cd ../puppet-hiera/
 massimiliano.adamo  GA0428-MADAMO ~ repos … modules ~ voxpupuli ~ puppet-hiera ~ modulesync $ hub pull-request -p -m "modulesync ${version}" -l "modulesync"
branch 'modulesync' set up to track 'origin/modulesync'.
Everything up-to-date
Error creating pull request: Forbidden (HTTP 403)
You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later.```
I'll do them one by one, but it will take some.

<@U1PC2RAH0>, I noticed that you have merged some of the PR. Now I ran it in chunks on all the modules and there may be a few other PRs

if you set an environment token you should not have those small rate limits

I have set the the following environment token:
```$GITHUB_TOKEN $GITHUB_BASE_URL $CHANGELOG_GITHUB_TOKEN```


but also msync should have raised the PRs

<@U1PC2RAH0> Happy Birthday! :tada: :birthday: :voxpupuli: :smile:

wrt augeas issue.. it’s related to `post_resource_eval`…

when changing the line 46 here to `false` it works: <https://github.com/voxpupuli/puppet-augeasproviders_core/blob/d3fc5676040291aaa3023e7102af4ca297691621/lib/puppet/provider/augeasprovider/default.rb#L46>

I guess I reproduced it now with Ruby.. the problem is `aug.save!` followed by `aug.load!`

just 140 issues to solve before this one :sunglasses:

I’m not sure if this is a bug or a feature :)

Is anyone working on, or using puppetwebhook? I have a dependency conflict with camptocamp systemd

ok with no shouts of pain these have been archived and set to read only into the toybox. A blog post will be released to clarify this and the future direction of PDK

<https://github.com/puppetlabs-toy-chest/pct>

<https://github.com/puppetlabs-toy-chest/prm>