AUTOMATE ALL THE THINGS!

I'm gonna ask before doin anything wrong again 🙂 ....can I merge that now?

I think it's good

Here goes, and thanks for the reviews!

and then one last step 😉

bundle exec rake release

after switching on the right branch

Done:

~/src/puppet-network  master  be rake release                       
To use retry middleware with Faraday v2.0+, install `faraday-retry` gem
Cleaning for module build
Bumping version from 1.1.0 to 1.1.1-rc0

hey hey, everything looks good now at 1.1.0.

💯

🍻 Thanks again.

20-fs.conf contents:
fs.inotify.max_user_watches = 8193
.

it looks like when a specific target is given the module overwrites the contents 🤔 there should be 2 values at the moment..

but that happens just on puppet7.. or maybe it is race condition if something was parallelised on puppet7

(or maybe some dependent gem has different version on P7 and behaves differently)

yep.. on second apply both lines appear:

2. 20-fs.conf contents:
fs.inotify.max_user_watches = 8193
fs.nr_open = 100001

yep.. on second apply both lines appear:

2. 20-fs.conf contents:
fs.inotify.max_user_watches = 8193
fs.nr_open = 100001

so 3rd apply is idempotent..

with puppet 6 file is correct from the first run

🤔

let me share this in the PR comments

ewoud: now that beaker ships a rubocop config, should it also have rubocop as dependency? otherwise we need to as it as deps to each beaker plugin

bastelfreak: that's the tricky bit I think - you kind of do want that, but it's a dev dep and not a runtime dep

yes :(

bastelfreak: so I'm starting to lean to a beaker-rubocop gem that they all depend on

ah thats good

but then wouldn't it be better to have a voxpupuli-rubocop gem for all our gems?

ah

we could do that as well. but keep the rubocop config in beaker?

or maybe have a generic rubocop config in voxpupuli-rubocop

I'd go for a generic rubocop config that we prefer for all our gems