https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v
    those are two steps. first create a release pr. when that's merged, run the release task
  • n
    ahh, "when that's merged".... that is what I didn't grok when reading the doc.
  • n
    Okay, release PR, for review please: https://github.com/voxpupuli/puppet-network/pull/296
  • n
    Okay, release PR, for review please: https://github.com/voxpupuli/puppet-network/pull/296
  • n
    (sorry... I feel dumb)
  • n
    ahh, "when that's merged".... that is what I didn't grok when reading the doc.
  • s
    Maybe we can add 2 sub-titles because this really is a 2 step process: 1. Prepare the release 2. Do the release
  • v
    I'm really open to doc enhancements
  • s
    is filling a PR
    🎉 1
  • v
    \o/
  • s
  • s
  • s
    has done the whole thing from the browser and feels dirty :-)
  • b
    you get used to the feeling 😛
    😅 1
  • n
    Should I just changelog generator do its thing, even though its putting closed issues in the wrong place? see https://github.com/voxpupuli/puppet-network/pull/296#discussion_r1160345103
  • b
    I think that's fine, because of the accidental rc release
    👍 1
  • s
  • s
    Should not it be v1.0.2-rc0 ?
  • s
    if it's some RC…
  • s
    maybe just removing the tag and running GCG will "fix" this ?
  • b
  • b
    I woudl just accept that the rc release and the related changelog is broken
  • b
    and hope that nobody notices
  • s
    Yeah, but I think that releasing 1.0.2 will fail because the tag already exist at GitHub
  • b
    I suggested in the PR that the next release should be 1.1.0
  • s
    Awesome 🙂
  • s
    No issue then 😉
  • b
    just ignore everything in the past, always look forward 😄
  • n
    oh that pushed a tag and a forge release out too? facepalm yikes
  • n
    okay, moving forward.... 1.1.0 release prep PR is ready
1...404405406...648Latest