there was probably a good explanation in the PR where I added it to voxpupuli-puppet-lint-plugins

Add puppet-lint-top_scope_facts-check

I did some tests on our modules and didn't notice any false positives.
<https://github.com/mmckinst> maintains two plugins. We already use their
awesome puppet-lint-legacy_facts-check plugin.
puppet-lint-top_scope_facts-check is a good addition to it. This points
out facts being accessed via top scope like `${::kernel}`. Most of the
occurrences can also be autofixed.

https://github.com/voxpupuli/voxpupuli-puppet-lint-plugins/pull/5 mhm

https://github.com/voxpupuli/voxpupuli-puppet-lint-plugins/pull/5 mhm

yep

and indeed if i switch off topscope facts, and do

"${::kernel} foo"

it doesn't highlight it as a problem

I've raised the issue with top_scope_facts-check in https://github.com/mmckinst/puppet-lint-top_scope_facts-check/issues/10

I've raised the issue with top_scope_facts-check in https://github.com/mmckinst/puppet-lint-top_scope_facts-check/issues/10

WARNING: top scope fact instead of facts hash on line 6 (check: top_scope_facts)
WARNING: use $mymodule::foo::var instead of $::mymodule::foo::var on line 6 (check: topscope_variable)

Incidentally now when i run it I'm getting both outputs ^

whereas i'm sure I only got top_scope_facts earlier

whereas i'm sure only got top_scope_facts earlier

whereas i'm sure I only got top_scope_facts earlier

I think the implementation of puppet-lint-legacy_facts-check and puppet-lint-top_scope_facts-check should be checked. maybe they can be combined/one check is obsolete

aye possibly

o/ This is a call for testers: I just released a gem named 'yaml-sort' with the purpose of sorting YAML data e.g. in Hiera files. If you are the kind of person who likes to see things in a predictable order, you may want to give it a try :-D

I tested this against my control-repo hiera data and some Rails i18n translations with great success, but I am sure edge cases will be found. The code is here: https://github.com/smortex/yaml-sort

smortex: o/

bastelfreak: o/

ah, thats nice for my control repo

would also be nice for our data in modules

Hehe, might :-) I tries hard to keep the style of what is in the YAML file (e.g. quotted strings and unquoted ones, spacing before list items, comments) that you can't do with just parsing and saving

I will be happy to have the results of your tests in your control repo

I guess some contol-comments will be required for lists that should not be sorted, not hit it directly but I saw some ordering change in aliases of webservers which trigger some resources in puppet

I can imagine situations where an array must not be touched ;-)

details, details :D

"example.com www.example.com example.net www.example.net" became "example.com example.net www.example.com www.example.net" in dehydrated config so it was triggered to refresh the certificate. Likewise for the aliases of the domain in the webserver config file.

Really harmless in this case, affected only 2 nodes out of a few dozens

an option to only sort the yaml keys and not their values would be nice

yeah, maybe a flag to opt-out of sorting lists / dictionaries on demand

That's the reason for my CFT, gather other people feedback!