bastelfreak
04/20/2022, 5:57 PMKeith Ward
04/20/2022, 5:59 PMI did some tests on our modules and didn't notice any false positives.
<https://github.com/mmckinst> maintains two plugins. We already use their
awesome puppet-lint-legacy_facts-check plugin.
puppet-lint-top_scope_facts-check is a good addition to it. This points
out facts being accessed via top scope like `${::kernel}`. Most of the
occurrences can also be autofixed.
bastelfreak
04/20/2022, 5:59 PMbastelfreak
04/20/2022, 5:59 PMKeith Ward
04/20/2022, 5:59 PMKeith Ward
04/20/2022, 6:06 PM"${::kernel} foo"
it doesn't highlight it as a problemKeith Ward
04/20/2022, 6:21 PMKeith Ward
04/20/2022, 6:21 PMKeith Ward
04/20/2022, 6:22 PMWARNING: top scope fact instead of facts hash on line 6 (check: top_scope_facts)
WARNING: use $mymodule::foo::var instead of $::mymodule::foo::var on line 6 (check: topscope_variable)
Incidentally now when i run it I'm getting both outputs ^Keith Ward
04/20/2022, 6:22 PMKeith Ward
04/20/2022, 6:22 PMKeith Ward
04/20/2022, 6:22 PMbastelfreak
04/20/2022, 6:33 PMKeith Ward
04/20/2022, 6:41 PMVoxBot
04/20/2022, 7:19 PMVoxBot
04/20/2022, 7:20 PMVoxBot
04/20/2022, 7:28 PMVoxBot
04/20/2022, 7:29 PMVoxBot
04/20/2022, 7:29 PMVoxBot
04/20/2022, 7:30 PMVoxBot
04/20/2022, 7:33 PMVoxBot
04/20/2022, 7:33 PMVoxBot
04/20/2022, 7:35 PMVoxBot
04/20/2022, 7:35 PMVoxBot
04/20/2022, 7:40 PMVoxBot
04/20/2022, 7:44 PMVoxBot
04/20/2022, 7:44 PMVoxBot
04/20/2022, 7:45 PMVoxBot
04/20/2022, 7:47 PMVoxBot
04/20/2022, 7:47 PM