I am good at giving feedback/complaining!

:-D

https://github.com/voxpupuli/gha-puppet/pull/16 our shared workflows are growing \o/

Nice!

Hi, I recently create 2 PRs (https://github.com/voxpupuli/puppet-openvpn/pull/431 + https://github.com/voxpupuli/puppet-openvpn/pull/432), I hope its in mind of the module.

Hi, I recently create 2 PRs (https://github.com/voxpupuli/puppet-openvpn/pull/431 + https://github.com/voxpupuli/puppet-openvpn/pull/432), I hope its in mind of the module.

Anyway, I would like to ask, what did you think about to drop the easy-rsa 2 support? This could be simplify the module in max.

This message was deleted.

set the channel topic: This room is synced with #voxpupuli on libera.chat IRC | Vox Pupuli is a collective of modules, tools, and maintainers | Join us and check out some open PRs https://voxpupuli.org/ | Join our monthly sync http://pup.pt/vox-sync-agenda

Does someone have an idea, what this kind of issue is? (https://github.com/voxpupuli/puppet-openvpn/runs/6110711679?check_suite_focus=true)

An error occurred while loading ./spec/defines/openvpn_server_spec.rb.
Failure/Error:
    on_supported_os.each do |os, facts|
      context "on #{os}" do
        let(:facts) do
          facts
        end
        let(:title) { 'test_server' }
  
        server_directory = case facts[:os]['family']
                           when 'CentOS', 'RedHat'
                             if facts[:os]['release']['major'] == '8'

NoMethodError:
  undefined method `split' for nil:NilClass
# ./vendor/bundle/ruby/2.7.0/gems/rspec-puppet-facts-2.0.3/lib/rspec-puppet-facts.rb:160:in `block in on_supported_os_implementation'
# ./vendor/bundle/ruby/2.7.0/gems/rspec-puppet-facts-2.0.3/lib/rspec-puppet-facts.rb:150:in `map'
# ./vendor/bundle/ruby/2.7.0/gems/rspec-puppet-facts-2.0.3/lib/rspec-puppet-facts.rb:150:in `on_supported_os_implementation'
# ./vendor/bundle/ruby/2.7.0/gems/rspec-puppet-facts-2.0.3/lib/rspec-puppet-facts.rb:45:in `on_supported_os'
# ./spec/defines/openvpn_server_spec.rb:6:in `block in <top (required)>'
# ./spec/defines/openvpn_server_spec.rb:5:in `<top (required)>'
No examples found.

Before I do a rebase, everything works fine (https://github.com/voxpupuli/puppet-openvpn/runs/6094294366?check_suite_focus=true). In actions, I only see a factordb update (1.1.5 -> 1.1.6). Not sure, if this is the root cause.

first of all, I'd suggest to use do |os, os_facts| so let and the regular variable do not overlap

and the facterdb could be it, if operatingsystemrelease as a fact is missing

(which https://github.com/voxpupuli/facterdb/commit/659888803b45bbed26a29c4ff00139f3d0683c52 is)

smortex: Does yaml-sort really need ruby 2.7 or is that just the minimum version you've tested with?

guess we need more spec tests in facterdb

I will check if facter doesn't support that fact on arch or if facter is broken/misses a dep

I believe in the past it presented the kernel major version as the OS release

yes

smortex: Would you like to enable issues on your github project? I've got valid hiera that causes yaml-sort to explode :)

https://github.com/voxpupuli/facterdb/pull/246/checks looks like we have a few factsets where operatingsystemrelease or operatingsystemmajrelease is nil, interesting

"an option to only sort the yaml keys and not their values would be nice" +1

smortex: Also... https://gist.github.com/alexjfisher/fa7e5da1195799c867cac4f07677c37c

@bastelfreak since it blocks the CI, whats the next to step? Revert the PR? Exclude Arch from metadata.json? Pin factordb? Update https://github.com/voxpupuli/rspec-puppet-facts/blob/0df5a5d82b48f7bc87016e46b247b69a6f5c3302/lib/rspec-puppet-facts.rb#L152-L165 to use the new facts instead legacy facts?

@bastelfreak since it blocks the CI, whats the next to step? Revert the PR? Exclude Arch from metadata.json? Pin factordb? Update https://github.com/voxpupuli/rspec-puppet-facts/blob/0df5a5d82b48f7bc87016e46b247b69a6f5c3302/lib/rspec-puppet-facts.rb#L152-L165 to use the new facts instead legacy facts?

for now please pin facterdb to 1.15.0 in the Gemfile

Feels strange, but fine - https://github.com/voxpupuli/puppet-openvpn/pull/432/files#diff-d09ea66f8227784ff4393d88a19836f321c915ae10031d16c93d67e6283ab55f

that will be overwritten by next modulesync sync and by then we probably figured out how to fix this

afisher: it is tested on 2.7+ so all supported versions of Ruby should be fine

This message was deleted.