redhat 9 didn't seem to work for me

oh, hmm, I think there is no magic for redhat at all

so much magic going on here...

we support centos 9

if you add centos 9 to metadata.json, beaker will pull in quay.io/centos/centos:stream9

https://github.com/voxpupuli/puppet-dbbackup/pull/34 as example

https://github.com/voxpupuli/puppet-dbbackup/pull/34 as example

afisher: https://github.com/voxpupuli/puppet-lint-topscope-variable-check/pull/12 ping :)

I'm looking at https://github.com/puppetlabs/hiera/compare/3.8.0...3.9.0 but is there any real difference between 3.8.0 and 3.9.0?

or really, https://github.com/puppetlabs/hiera/compare/3.8.1...3.9.0

interesting version bump

https://github.com/puppetlabs/puppetlabs-accounts/pull/408/files yey, puppet adopts our voxpupuli-puppet-lin-plugins :D

yep i noticed that too, it's why I've found a bit of a weird issue with puppet-lint-top_scope_facts-check it's very insistent that every $::var is a top scope fact, even if it's a scoped variable. So it's explicitly converting things like

$::mymodule::foo

into

$facts['mymodule']::foo

which as you can imagine doesn't end well. I'm wondering if i should PR s similar fix to what Alex did for the topscope-variable-check

mhm that sounds like a bug

are you sure that is caused by that plugin

and not the top scope variable check

it seems to be

WARNING: top scope fact instead of facts hash on line 6 (check: top_scope_facts)

interesting

check out https://github.com/voxpupuli/puppet-lint-topscope-variable-check/issues/13 and https://github.com/puppetlabs/puppet-lint/issues/41

check out https://github.com/voxpupuli/puppet-lint-topscope-variable-check/issues/13 and https://github.com/puppetlabs/puppet-lint/issues/41

a few plugins are interfering a bit and I think we never noticed that at vox pupuli bevause we rolled out one at a time

perhaps a better way is to use getvar() then?

also, IMHO it should recognize $:mymodule:foo should be $mymodule::foo

facts never have $(::)?.+::.+

I think a good first step is to fix https://github.com/puppetlabs/puppet-lint/issues/41 so it only works on variables, not facts

and someone should check if we need puppet-lint-legacy_facts-check and puppet-lint-top_scope_facts-check

tbh from my side top_scope_facts-check seems to be be superceeded by puppet-lint-legacy_facts-check

I share that impression