# voxpupuli
- v
VoxBot
03/27/2023, 1:15 PMlooks like it's an opinionated config on top of RuboCop - v
VoxBot
03/27/2023, 1:16 PMBecause StandardRB is essentially a wrapper on top of RuboCop
- v
VoxBot
03/27/2023, 1:16 PMah - y
Yury Bushmelev
03/27/2023, 1:27 PMCopy code
Here 2nd line do not need theif mount.key?('opts') a << mount['opts'] if mount.key?('opts') else a << mount['opts'] = 'z' end
, right? It’s useless as I seeif mount.key?('opts') - v
VoxBot
03/27/2023, 1:28 PMI'd write it as: mounts['opts'] ||= 'z' ; a << mounts['opts'] - v
VoxBot
03/27/2023, 1:28 PMway clearer in what it's doing IMHO - v
VoxBot
03/27/2023, 1:29 PMthough it may actually be slightly different: ||= also replaces nil with 'z' - v
VoxBot
03/27/2023, 1:30 PMso this is the exact replacement in terms of behavior: mounts['opts'] = 'z' unless mounts.key('opts') ; a << mounts['opts'] - y
Yury Bushmelev
03/27/2023, 1:35 PMwell.. tbh, I see no point to define
asmount['opts']
.. it’ll break thenil
commanddocker - y
Yury Bushmelev
03/27/2023, 1:35 PMso
should be good enough from my point of viewa << mounts['opts'] ||= 'z' - y
Yury Bushmelev
03/27/2023, 1:40 PMthough.. maybe I’ll leave it as it is for now until end of rubocop cleanup.. - v
VoxBot
03/27/2023, 1:40 PMI wouldn't try to be smart and combine it in a single line - v
VoxBot
03/27/2023, 1:41 PMbecause || and ||= are very close, it's too easy to misread or make a mistake - y
Yury Bushmelev
03/27/2023, 1:42 PMI see the point 🤔 well.. I’ll leave “FIXME” comment there for now - y
Yury Bushmelev
03/27/2023, 1:43 PMthough TODO is better - y
Yury Bushmelev
03/27/2023, 1:47 PMAnother thing I’m not sure about is https://github.com/voxpupuli/beaker-docker/blob/master/spec/beaker/hypervisor/docker_spec.rb#L555 - y
Yury Bushmelev
03/27/2023, 1:47 PMAnother thing I’m not sure about is https://github.com/voxpupuli/beaker-docker/blob/master/spec/beaker/hypervisor/docker_spec.rb#L555 - y
Yury Bushmelev
03/27/2023, 1:48 PMCopy code
rubocop complains about empty blockFakeFS do File.open('/.dockerenv', 'w') {} docker.provision
.. as I understand this creates an empty file in FakeFS and closes it immediately (because block is empty){} - y
Yury Bushmelev
03/27/2023, 1:49 PMafter reading some docs about the File module I’d say it’s ok to drop the {} and add File.close() after - y
Yury Bushmelev
03/27/2023, 1:49 PMor maybe add the comment about this into the block (which is one line longer then) - v
VoxBot
03/27/2023, 1:56 PMI'd go with FileUtils.touch in this case - v
VoxBot
03/27/2023, 1:56 PMit just ensures the file exists - y
Yury Bushmelev
03/27/2023, 1:56 PMI guess this is ok:File.open('/.dockerenv', 'w').close - y
Yury Bushmelev
03/27/2023, 1:56 PMah.. good idea, let me try - y
Yury Bushmelev
03/27/2023, 1:59 PM
works fine (at least unit tests are good), ty!touch - r
Robert Waffen
03/27/2023, 2:14 PMmay somebody pls have a look here? https://github.com/voxpupuli/beaker-hiera/pull/19 why is ruby 2.4 still required when i removed it from the code as dependency? - r
Robert Waffen
03/27/2023, 2:14 PMmay somebody have a look here? https://github.com/voxpupuli/beaker-hiera/pull/19 why is ruby 2.4 still required when i removed it from the code as dependency? - r
Robert Waffen
03/27/2023, 2:15 PMmay somebody pls have a look here? https://github.com/voxpupuli/beaker-hiera/pull/19 why is ruby 2.4 still required when i removed it from the code as dependency? - v
VoxBot
03/27/2023, 2:16 PMthose are required branches in GH - v
VoxBot
03/27/2023, 2:17 PMthe trick we use in gha-puppet is to add a last step that's a dummy step which depends on all the previous steps