https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • s

    simonhoenscheid

    03/27/2023, 8:30 AM
    Just prep a release, if somebody acceps the PR, you go ahead
  • s

    simonhoenscheid

    03/27/2023, 8:30 AM
    https://voxpupuli.org/docs/releasing_version/
  • v

    voxel

    03/27/2023, 8:46 AM
    Is anywhere a recommendation to use erb or epp templates?
  • v

    VoxBot

    03/27/2023, 8:47 AM
    we (foreman) have been slowly moving to epp
  • v

    VoxBot

    03/27/2023, 8:47 AM
    mostly as it gives more strict control over what's rendered (context, types)
    👍 1
  • v

    voxel

    03/27/2023, 8:47 AM
    for any reason? or just because?
  • v

    voxel

    03/27/2023, 8:47 AM
    ok
  • v

    voxel

    03/27/2023, 8:48 AM
    Thanks
  • v

    VoxBot

    03/27/2023, 8:55 AM
    we want to migrate to epp and require all new templates to be epp
  • v

    VoxBot

    03/27/2023, 8:56 AM
    our guidelines are here: https://voxpupuli.org/docs/reviewing_pr/ (and mention epp)
  • b

    bastelfreak

    03/27/2023, 8:56 AM
    @Robert Waffen whoever likes to do a release can do that
  • r

    Robert Waffen

    03/27/2023, 8:59 AM
    ah okay, the how and who is now more clear to me. thx
  • y

    Yury Bushmelev

    03/27/2023, 10:56 AM
    epp should be faster as well (no need to bring the whole context)
  • v

    VoxBot

    03/27/2023, 11:01 AM
    I think with ERB the most common problem is that it's very easy to make a mistake and end up rendering an empty string instead of a variable
  • v

    VoxBot

    03/27/2023, 11:01 AM
    like if you make a typo in the variable name, refactor the variable in a class
  • v

    VoxBot

    03/27/2023, 11:02 AM
    with EPP you can validate your inputs, making it a compile error
    👍🏻 1
  • v

    VoxBot

    03/27/2023, 11:02 AM
    and IMHO that removes the need for a lot of very detailed testing
  • v

    VoxBot

    03/27/2023, 12:26 PM
    https://www.githubstatus.com/ meh
  • y

    Yury Bushmelev

    03/27/2023, 12:35 PM
    yeah, I hit this..
  • y

    Yury Bushmelev

    03/27/2023, 12:37 PM
    trying to cleanup more rubocop issues in
    beaker-docker
    .. it looks like I did some of them already 🤔 @bastelfreak you’ve merged all your commits from your branch yesterday, right?
  • y

    Yury Bushmelev

    03/27/2023, 12:39 PM
    hmm.. I guess my fork was not really synced with the upstream 😞
  • b

    bastelfreak

    03/27/2023, 12:39 PM
    I merged yours and mine
  • y

    Yury Bushmelev

    03/27/2023, 12:44 PM
    yes, I found the problem.. my fork shows latest commits on Github but nothing is in
    git log
    after
    git pull
  • y

    Yury Bushmelev

    03/27/2023, 12:45 PM
    tried to clone the repo again and it’s the same.. so it’s some GH problem it seems
  • v

    VoxBot

    03/27/2023, 12:47 PM
    bastelfreak: I'm glad it's not just me
  • v

    VoxBot

    03/27/2023, 12:47 PM
    kind of annoying when you can't push
  • v

    VoxBot

    03/27/2023, 12:59 PM
    now since this seems to be something bigger: the github blog publishes a monthly availability report with post portems. always nice to read
  • y

    Yury Bushmelev

    03/27/2023, 1:04 PM
    luckily it’s possible to add another remote origin, so I can continue with rubocop cleanup 🙂
  • v

    VoxBot

    03/27/2023, 1:14 PM
    TIL: https://github.com/testdouble/standard exists
  • v

    VoxBot

    03/27/2023, 1:15 PM
    so StandardRB and RuboCop can fight against each other?
1...383384385...648Latest