https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • y
    @bastelfreak shall it be 1.5.0 or 1.4.1?
  • v
    I always generate the changelog and look at the changes to determine that
  • y
    well.. there was quite a lot of changes.. so I’d say 1.5 is better
  • v
    in my experience, it's very often a minor release
  • v
    we rarely have bugfix releases
  • v
    we just don't have any bugs :P
  • y
    at least these: +- Simplify port detection code \#95 (ekohl) +- Deal with docker\_cmd being an array and remove use of =~ \#93 (ekohl) +- Remove yard rake tasks \#96 (ekohl) +- Use ssh-keygen -A on Red Hat-based distros & SuSE/SLES \#73 (ekohl)
  • y
    ok, 1.5.0 then 🙂
  • v
    yep, at least the last one would qualify as an enhancement so 1.5.0 indeed
  • y
    pls https://github.com/voxpupuli/beaker-docker/pull/105 (mark it as skip-changelog btw)
  • y
    pls https://github.com/voxpupuli/beaker-docker/pull/105 (mark it as skip-changelog btw)
  • v
  • v
  • v
  • v
    sure
  • r
    its a lot, but also a lot of the same
  • v
    I created one commit per rubocop. so you could review each commit if you like
  • r
    that doesn make it easier ^^
  • r
    but i klicked trough it. looks okay. but this new lambda looks strange
  • v
  • v
    https://github.com/Yelp/puppet-netstdlib/pull/12/files what kind of nonsense or bitcoin mining is this
  • v
    and why do I get an email notification about it
  • v
    perhaps you're watching the repo?
  • v
    more of a rhetorical question :D
  • v
    ewoud: do you want to review https://github.com/voxpupuli/beaker/pull/1792 ?
  • v
    ah nice :D
  • v
    bastelfreak: I was literally typing the review comment already :D
  • v
    I thought a bit about a shared github action in beaker for beaker plugins, and I think versioning that properly is a bit ugly and I think I prefer a dedicated repo like gha-gems. Where we store different workflows for gems
  • v
    ewoud: are you fine with merging https://github.com/voxpupuli/beaker/pull/1792? I would like to do a release afterwards
  • v
    bastelfreak: sure
1...379380381...648Latest