# voxpupuli
- v
VoxBot
03/23/2023, 9:22 AMthx for the election and congrats to every other pmc member :) - c
Craig Gumbley
03/23/2023, 10:55 AMCongratulations and thank you to all those involved 🙏 - d
David Sandilands
03/23/2023, 11:01 AMCongratulations voxpupuli - y
Yury Bushmelev
03/23/2023, 2:06 PMAfter [1] is merged can we have a release of
soon? I cannot drop `beaker-rspec`/`rspec-its` from thebeaker
because it’s still required by latestbeaker-docker
release.. 1. https://github.com/voxpupuli/beaker/pull/1788beaker - y
Yury Bushmelev
03/23/2023, 2:06 PMAfter [1] is merged can we have a release of
soon? I cannot drop `beaker-rspec`/`rspec-its` from thebeaker
because it’s still required by latestbeaker-docker
release.. 1. https://github.com/voxpupuli/beaker/pull/1788beaker - y
Yury Bushmelev
03/23/2023, 2:07 PMAfter [1] is merged can we have a release of
soon? I cannot drop `beaker-rspec`/`rspec-its` from thebeaker
because it’s still required by latestbeaker-docker
release.. 1. https://github.com/voxpupuli/beaker/pull/1788beaker - b
bastelfreak
03/23/2023, 2:13 PMI think we first should release beaker-docker, then the PRs for beaker, then a release - b
bastelfreak
03/23/2023, 2:15 PMdo you want to create a release PR for beaker-docker? - b
bastelfreak
03/23/2023, 2:36 PM@Yury Bushmelev https://github.com/voxpupuli/beaker-docker/pull/102👍🏻 1 - c
Craig Gumbley
03/23/2023, 3:00 PM👋 I’m wondering if this issue is best placed over at https://github.com/voxpupuli/puppet-lint-trailing_comma-check I think it’s ultimately happening because
does not get refreshed between eachtokens
… however I don’t think this is something that we can/will fix in puppet-lint any time soon (i’m not even sure how computationally sensible it would be at this point). In trailing_comma_check we could mitigate by doing something like thisfixCopy codedef fix(problem) comma = PuppetLint::Lexer::Token.new( :COMMA, ',', problem[:token].line, problem[:token].column ) idx = tokens.index(problem[:token]) # If the index is nil, this line may have been # amended by another fix. In that case, we raise # a NoFix exception which be handled by puppet-lint as # a no-op for this problem. # The problem can then be fixed on a subsequent run. raise PuppetLint::NoFix if idx.nil? tokens.insert(idx, comma) end - c
Craig Gumbley
03/23/2023, 3:00 PM👋 I’m wondering if this issue is best placed over at https://github.com/voxpupuli/puppet-lint-trailing_comma-check I think it’s ultimately happening because
does not get refreshed between eachtokens
… however I don’t think this is something that we can/will fix in puppet-lint any time soon (i’m not even sure how computationally sensible it would be at this point). In trailing_comma_check we could mitigate by doing something like thisfixCopy codedef fix(problem) comma = PuppetLint::Lexer::Token.new( :COMMA, ',', problem[:token].line, problem[:token].column ) idx = tokens.index(problem[:token]) # If the index is nil, this line may have been # amended by another fix. In that case, we raise # a NoFix exception which be handled by puppet-lint as # a no-op for this problem. # The problem can then be fixed on a subsequent run. raise PuppetLint::NoFix if idx.nil? tokens.insert(idx, comma) end - v
VoxBot
03/23/2023, 3:02 PMyes, I don't have permissions but https://github.com/puppetlabs/puppet-lint/issues/109 is another case where it's complaining about a plugin issue👍 1 - y
Yury Bushmelev
03/23/2023, 3:26 PMOMG, #75 was finally merged! \o/ - y
Yury Bushmelev
03/23/2023, 3:28 PMactually I’d like to squash it a bit but nvm, at least it’s merged finally 🙂 - y
Yury Bushmelev
03/23/2023, 3:29 PM@bastelfreak is there anything to do before I can proceed with cleaning up the rest of the .rubocop_todo in the beaker-docker? - b
bastelfreak
03/23/2023, 3:30 PMI think we should do a release now. then cleanup more, then drop ruby < 2.7 - y
Yury Bushmelev
03/23/2023, 3:30 PMah, ok.. main functionality was not touched so should be safe enough - y
Yury Bushmelev
03/23/2023, 3:31 PMlet me try to do a release PR 😄 - y
Yury Bushmelev
03/23/2023, 3:31 PMthere was some docs I believe - y
Yury Bushmelev
03/23/2023, 3:32 PMPlease note that in order to execute this rake task you must be in the Collaborators group on GitHub for the module in question.
- y
Yury Bushmelev
03/23/2023, 3:32 PMPlease also note that the task requires a configured gpg key in your local git settings
- y
Yury Bushmelev
03/23/2023, 3:33 PMnot sure I’m eligible 🙂 this is from https://voxpupuli.org/docs/releasing_version/ - b
bastelfreak
03/23/2023, 3:33 PMthat's for releasing modules - y
Yury Bushmelev
03/23/2023, 3:33 PMah, right - y
Yury Bushmelev
03/23/2023, 3:33 PM - b
bastelfreak
03/23/2023, 3:34 PMfor gems, you can bump the version in the gemspec, run the changelog task, create a PR - b
bastelfreak
03/23/2023, 3:34 PMah, yes - y
Yury Bushmelev
03/23/2023, 3:34 PMok, let me follow the steps of part 1 - y
Yury Bushmelev
03/23/2023, 3:45 PMJust found small issue, fixed it here: https://github.com/voxpupuli/beaker-docker/pull/103 - y
Yury Bushmelev
03/23/2023, 3:45 PMJust found small issue, fixed it here: https://github.com/voxpupuli/beaker-docker/pull/103