https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v

    VoxBot

    03/17/2023, 7:59 PM
    rusty: have you looked at what we do in VP? https://github.com/voxpupuli/modulesync_config/blob/master/moduleroot/.rubocop.yml.erb
  • v

    VoxBot

    03/17/2023, 7:59 PM
    those stupid slack threads...
  • v

    VoxBot

    03/17/2023, 7:59 PM
    by externalizing most of the config to a gem it's easy to update a base config
  • v

    VoxBot

    03/17/2023, 8:00 PM
    ewoud: the message comes from a thread, but I cant find' that in slack :D
  • v

    VoxBot

    03/17/2023, 8:00 PM
    and it's pretty trivial to not template it at all, but still benefit from the defaults
  • b

    bastelfreak

    03/17/2023, 8:01 PM
    @rusty @CVQuesty ^
  • v

    VoxBot

    03/17/2023, 8:01 PM
    so to clarify: I have issues with both PDK itself, and pdk-templates, but I'd start with working on pdk-templates and voxpupuli/modulesync_config alignment
  • v

    VoxBot

    03/17/2023, 8:02 PM
    I'd say that for persona 1) removing as much synced code as possible (like we did with our modulesync_config) is a huge win
  • v

    VoxBot

    03/17/2023, 8:02 PM
    and for persona 2) it's also a win
  • v

    VoxBot

    03/17/2023, 8:02 PM
    nods
  • v

    VoxBot

    03/17/2023, 8:02 PM
    so that's where I started
  • v

    VoxBot

    03/17/2023, 8:02 PM
    syncing files is an antipattern and that should be reduced. by doing that vox pupuli and puppet setup come automatically closer
  • v

    VoxBot

    03/17/2023, 8:03 PM
    exactly
  • y

    Yury Bushmelev

    03/17/2023, 8:06 PM
    nods here too
  • c

    Craig Gumbley

    03/17/2023, 8:07 PM
    @bastelfreak yeah agree
  • y

    Yury Bushmelev

    03/17/2023, 8:07 PM
    where can I look for a modern enough Rakefile to sync the beaker-docker’s with?
  • c

    Craig Gumbley

    03/17/2023, 8:07 PM
    Scaffolding is the way I want to go
  • v

    VoxBot

    03/17/2023, 8:07 PM
    https://github.com/voxpupuli/beaker/pull/1784 victory! at least with just Ruby 3.2 it's green
  • c

    Craig Gumbley

    03/17/2023, 8:07 PM
    but include guard rails to keep people within known bounds for compatibility
  • v

    VoxBot

    03/17/2023, 8:08 PM
    now to run on all Ruby versions and see what else breaks
  • b

    bastelfreak

    03/17/2023, 8:08 PM
    @Yury Bushmelev https://github.com/voxpupuli/puppet-grafana/blob/master/Rakefile that's our latest Rakefile
    🙇🏻 1
  • b

    bastelfreak

    03/17/2023, 8:08 PM
    @Yury Bushmelev https://github.com/voxpupuli/puppet-grafana/blob/master/Rakefile that's our latest Rakefile
  • v

    VoxBot

    03/17/2023, 8:08 PM
    ewoud++
  • d

    Dr Bunsen Honeydew

    03/17/2023, 8:08 PM
    ewoud leveled up! (Karma: 3)
  • v

    VoxBot

    03/17/2023, 8:09 PM
    Craig: if you want to go that route, perhaps make sure the Ruby tooling can actually read a config file?
    👍 1
  • b

    bastelfreak

    03/17/2023, 8:09 PM
    @Yury Bushmelev oh you mean for gems? one sec
  • v

    VoxBot

    03/17/2023, 8:09 PM
    I mean, perhaps not for everything it'll work, but for spec_helper.rb if there are known toggles then perhaps reading a config file is better
  • y

    Yury Bushmelev

    03/17/2023, 8:10 PM
    @bastelfreak I’d say we should have the same Rakefile across the beaker plugins (at least)
  • y

    Yury Bushmelev

    03/17/2023, 8:10 PM
    @bastelfreak I’d say we should have the same Rakefile across the beaker plugins (at least)
  • b

    bastelfreak

    03/17/2023, 8:11 PM
    yeah that's my longterm plan. I think for now the beaker-docker Rakefile can stay as it it in master. It has the tasks for rubocop, changelog generator and unit tests
1...371372373...648Latest