https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v

    VoxBot

    03/14/2023, 5:16 PM
    but that needs an update: https://github.com/voxpupuli/modulesync_config/blob/c0433f4d04fcb54355851c4424e8b441b2654e14/moduleroot/Dockerfile.erb#L11 is oudated
  • v

    VoxBot

    03/14/2023, 5:16 PM
    kind of weird we're using Ruby 2.7 but Puppet 6
  • v

    VoxBot

    03/14/2023, 6:07 PM
    bastelfreakas promised: https://github.com/voxpupuli/modulesync_config/pull/816
  • v

    VoxBot

    03/14/2023, 6:09 PM
    but of course CI is my personal nemesis...
  • j

    jhoblitt

    03/14/2023, 6:18 PM
    it looks like the bundler cache might need to be flushed
  • j

    jhoblitt

    03/14/2023, 6:19 PM
    welp, that didn't fix it
  • v

    voxel

    03/14/2023, 7:00 PM
    can I have a review for https://github.com/voxpupuli/puppet-varnish/pull/17 and https://github.com/voxpupuli/puppet-varnish/pull/16 plz... both quite small
  • v

    voxel

    03/14/2023, 7:00 PM
    can I have a review for https://github.com/voxpupuli/puppet-varnish/pull/17 and https://github.com/voxpupuli/puppet-varnish/pull/16 plz... both quite small
  • p

    Pat Riehecky

    03/14/2023, 7:02 PM
    To prevent those sorts of README issues in the future, did we want a
    rake
    task to run
    prettier
    on the markdown files?
    👍 2
  • b

    bastelfreak

    03/14/2023, 8:16 PM
    maybe not a bad idea
  • b

    bastelfreak

    03/14/2023, 8:17 PM
    maybe voxpupuli-test is a good place for that
  • j

    jhoblitt

    03/14/2023, 8:39 PM
    it would also be nice to require PRs to be appropriately labeled
  • j

    jhoblitt

    03/14/2023, 8:39 PM
    I just started doing that at $day_job with a gha
  • j

    jhoblitt

    03/14/2023, 8:40 PM
    Copy code
    ---
    name: "Pull Request Labels"
    "on":
      pull_request:
        types: ["opened", "labeled", "unlabeled", "synchronize"]
    jobs:
      label:
        runs-on: "ubuntu-latest"
        steps:
          - uses: "mheap/github-action-required-labels@v3"
            with:
              mode: "exactly"
              count: 1
              labels: "enhancement, bug, skip-changelog"
              add_comment: true
              message: "This PR is being prevented from merging because of missing or incorrect labels."
  • d

    Dr Bunsen Honeydew

    03/14/2023, 8:40 PM
    ```- took a dive. (Karma: -104)
  • v

    VoxBot

    03/14/2023, 8:40 PM
    pool ```
  • v

    VoxBot

    03/14/2023, 8:40 PM
    poor*
  • j

    jhoblitt

    03/14/2023, 8:40 PM
    can't trust that guy
  • a

    Alex Fisher

    03/14/2023, 9:20 PM
    @binford2k Was there any progress on 'trusted contributors' actually being able to merge code? I think this was originally possible. re. https://github.com/puppetlabs/puppetlabs-stdlib/pull/1301#pullrequestreview-1340295404
  • b

    bastelfreak

    03/14/2023, 9:21 PM
    yes it was possible
  • b

    bastelfreak

    03/14/2023, 9:21 PM
    I think someone wanted to check if trusted contributors could be added to the codeowners
  • a

    Alex Fisher

    03/14/2023, 9:22 PM
    I think it came up at a monthly meeting. Maybe trusted contributors were going to be a separate group added to code owners??
  • a

    Alex Fisher

    03/14/2023, 9:22 PM
    yeah, ok, so I think we both remember it the same. 🙂
  • b

    bastelfreak

    03/14/2023, 9:25 PM
    I think, but I dont know for 100%, that you dsn only list grouos from the same org and trusted contributors are from a other org
    this 1
  • a

    Alex Fisher

    03/14/2023, 9:47 PM
    Is https://github.com/puppetlabs/puppet/commit/82cef2371352b648cc60aa7b7cedaa973c38ad35 going to be backported to Puppet 7?
  • a

    Alex Fisher

    03/14/2023, 9:50 PM
    Reading https://groups.google.com/g/puppet-dev/c/hFIjgvOa5J0 I guess not.
  • a

    Alex Fisher

    03/14/2023, 9:54 PM
    So whilst we can make the option configurable in rspec-puppet it's not going to be especially useful at this time to try setting
    include_legacy_facts
    to anything other than what it defaults to based on puppet version??
  • a

    Alex Fisher

    03/14/2023, 10:11 PM
    Even with puppet 8 (main branch), I get
    Copy code
    Could not autoload puppet/type/service: Could not autoload puppet/provider/service/freebsd: Could not autoload puppet/provider/service/init: undefined method `downcase'
    if rspec-puppet-facts doesn't include legacy facts.
  • a

    Alex Fisher

    03/14/2023, 10:11 PM
    Does anyone know how to get a stacktrace when using rspec-puppet?
  • b

    bastelfreak

    03/14/2023, 10:15 PM
    run it with --trace?
1...359360361...648Latest